Horizon container logs path chown'ing is not idempotent

Bug #1819626 reported by Bogdan Dobrelya on 2019-03-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Medium
Bogdan Dobrelya

Bug Description

Whenever /var/log/horizon/horizon.log recreated as a root,
the touch command fails, and the chown commands got skipped.
This results in idempotency issues when the logs path become
accessed under mismatching user.

Changed in tripleo:
importance: Undecided → Medium
milestone: none → stein-3
tags: added: idempotency

Fix proposed to branch: master
Review: https://review.openstack.org/642717

Changed in tripleo:
assignee: nobody → Bogdan Dobrelya (bogdando)
status: New → In Progress

Reviewed: https://review.openstack.org/642717
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=95e142d84eeaf82b23323bb3a8eab1e4f6a9e005
Submitter: Zuul
Branch: master

commit 95e142d84eeaf82b23323bb3a8eab1e4f6a9e005
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Mar 12 11:38:51 2019 +0100

    Fix idempotency for horizon container logs

    Whenever /var/log/horizon/horizon.log recreated as a root,
    the touch command fails, and the chown commands got skipped.
    This results in idempotency issues when the logs path become
    accessed under mismatching user.

    Fix this by making the chown command always applying disregard
    of the touch command results.

    Closes-Bug: #1819626

    Change-Id: Ied538dbc7dbd311361108747a1e89d1f5740eedd
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in tripleo:
status: In Progress → Fix Released
tags: added: queens-backport-potential rocky-backport-potential

Reviewed: https://review.openstack.org/642979
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0fc5b0efc8506efd7826e340292cb09beb7b2244
Submitter: Zuul
Branch: stable/rocky

commit 0fc5b0efc8506efd7826e340292cb09beb7b2244
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Mar 12 11:38:51 2019 +0100

    Fix idempotency for horizon container logs

    Whenever /var/log/horizon/horizon.log recreated as a root,
    the touch command fails, and the chown commands got skipped.
    This results in idempotency issues when the logs path become
    accessed under mismatching user.

    Fix this by making the chown command always applying disregard
    of the touch command results.

    Closes-Bug: #1819626

    Change-Id: Ied538dbc7dbd311361108747a1e89d1f5740eedd
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 95e142d84eeaf82b23323bb3a8eab1e4f6a9e005)

tags: added: in-stable-rocky

Reviewed: https://review.openstack.org/642718
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7761ae38d487bd074a3d5e2bab50924588772243
Submitter: Zuul
Branch: stable/queens

commit 7761ae38d487bd074a3d5e2bab50924588772243
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Mar 12 11:38:51 2019 +0100

    Fix idempotency for horizon container logs

    Whenever /var/log/horizon/horizon.log recreated as a root,
    the touch command fails, and the chown commands got skipped.
    This results in idempotency issues when the logs path become
    accessed under mismatching user.

    Fix this by making the chown command always applying disregard
    of the touch command results.

    Closes-Bug: #1819626

    Change-Id: Ied538dbc7dbd311361108747a1e89d1f5740eedd
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 95e142d84eeaf82b23323bb3a8eab1e4f6a9e005)

tags: added: in-stable-queens

This issue was fixed in the openstack/tripleo-heat-templates 10.5.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers