container image prepare doesn't support OVN/ODL

Bug #1816663 reported by Dan Prince
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Dan Prince

Bug Description

Trying to use the 'openstack overcloud container image prepare' command to generate container files for OVN or ODL will fail because the neutron_driver isn't set correctly. As such the resulting output files for won't upload any OVN (or ODL) images for deployment.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/637989

Revision history for this message
Steve Baker (steve-stevebaker) wrote :

FYI 'openstack overcloud container image prepare' is deprecated in favour of 'openstack tripleo container image prepare' which supports the same ContainerImagePrepare parameter that is used during deployment of overcloud, undercloud or standalone.

There is no relation between mistral and ContainerImagePrepare driven prepare.

https://docs.openstack.org/tripleo-docs/latest/install/containers_deployment/overcloud.html#preparing-overcloud-images

Revision history for this message
Dan Prince (dan-prince) wrote :

steve: thanks for this. Adding the functionality to the deprecated call doesn't break anything I don't think does it.

I'll move my scripts to the new version of the command.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/637989
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=a2c4d07df6f043b17accd229aacfcb6c669340b1
Submitter: Zuul
Branch: master

commit a2c4d07df6f043b17accd229aacfcb6c669340b1
Author: Dan Prince <email address hidden>
Date: Tue Feb 19 15:20:41 2019 -0500

    Allow 'container image prepare' to support drivers

    This updates the 'overcloud container image prepare' command
    so that it sets the neutron_driver variable correctly. This
    allows tripleo-common to detect if OVN or ODL drivers are in
    used and prepares the resulting output files for container
    images and parameters accordingly.

    Previously you could only access this functionality if you
    used the new ContainerImagePrepare workflow (requires Mistral).

    Change-Id: Icb5b20bfd98a704f3f33f739bc92f77550b52c26
    Closes-bug: #1816663

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 11.3.0

This issue was fixed in the openstack/python-tripleoclient 11.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/652934

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/rocky)

Reviewed: https://review.openstack.org/652934
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=e89a0a689aad0bf13b59c7718104525b376a5510
Submitter: Zuul
Branch: stable/rocky

commit e89a0a689aad0bf13b59c7718104525b376a5510
Author: Dan Prince <email address hidden>
Date: Tue Feb 19 15:20:41 2019 -0500

    Allow 'container image prepare' to support drivers

    This updates the 'overcloud container image prepare' command
    so that it sets the neutron_driver variable correctly. This
    allows tripleo-common to detect if OVN or ODL drivers are in
    used and prepares the resulting output files for container
    images and parameters accordingly.

    Previously you could only access this functionality if you
    used the new ContainerImagePrepare workflow (requires Mistral).

    Note: Bumps lower constraint for tripeo-common==9.5.0 to fix
    the lower constaints job.

    Change-Id: Icb5b20bfd98a704f3f33f739bc92f77550b52c26
    Closes-bug: #1816663
    (cherry picked from commit a2c4d07df6f043b17accd229aacfcb6c669340b1)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 10.7.0

This issue was fixed in the openstack/python-tripleoclient 10.7.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.