build-test-package does not fail on partial builds

[Quique Llorente]

In case we have a review with multiple changes and one of them fails at build it's RPM by build-test-package non of the changes is applied and the job continues, let's just make the job fail if one of the changes is not built.

One specific stuff have being using a Depends-On at github.com we are not prepared for it we ned to merge https://review.openstack.org/#/c/636114, but while we merge it

Example of review with githu.com depends-on, and job passing without applying THT changes:

https://review.openstack.org/#/c/636511/

The issue is that repo_buildt.skipped is the last package is cannot be built so it skip all of them.

repo_built definition
http://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/tree/roles/build-test-packages/tasks/dlrn-build.yml#n107

The use of it
http://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/tree/roles/build-test-packages/tasks/main.yml#n283

Also depending on the order of the changes the result is diffent since we are reusing the same register

[wes hayutin (weshayutin)]

I see in https://logs.rdoproject.org/11/636511/5/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/93b8ab2/

that tht was built and applied Feb 19 08:31:28 Updated: openstack-tripleo-heat-templates-10.3.1-0.20190219083034.25c6312.el7.noarch

I'm +1 on being defensive w/ regards to package failing to build and applied. I'd like to see more details

[Quique Llorente (quiquell)]

You have to look at patchset 2 where we have the Depends-On to github -> https://review.openstack.org/#/c/636511/2

Here are the log for that http://logs.rdoproject.org/11/636511/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/334c49f/logs/undercloud/home/zuul/

As you see there is no install-built-packages.log file there so THT change is build but not applied.

rpm version openstack-tripleo-heat-templates-10.3.1-0.20190213123753.9689f6e.el7.noarch
http://logs.rdoproject.org/11/636511/2/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/334c49f/logs/undercloud/var/log/extra/rpm-list.txt.gz

[wes hayutin (weshayutin)]

Being worked on here: https://review.openstack.org/#/c/636588/

[Alex Schultz (alex-schultz)]

Lowering to high as it's not breaking anything at the moment.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/654460

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/654460
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=c6478adc8666c6ba3e0d8c92bf133b9da143614f
Submitter: Zuul
Branch: master

commit c6478adc8666c6ba3e0d8c92bf133b9da143614f
Author: yatin <email address hidden>
Date: Mon Apr 22 19:39:58 2019 +0530

    Rely on artg_rdo_packages to inject gating repo

    Currently inject gating repo is triggered based on
    repo_built.skipped. This is wrong as repo_built.skipped
    is defined if the last project in the dependency change
    is skipped.
    This patch fixes it by relying on artg_rdo_packages
    variable. So whenever atleast 1 rdo packge is built
    inject repo will be triggered.

    Related-Bug: #1815744
    Change-Id: I3c363c82c12b356e9073289a6912edd878b0f6ab

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sagi Shnaidman (<email address hidden>) on branch: master
Review: https://review.opendev.org/636588
Reason: because long time passed since last update

[wes hayutin (weshayutin)]

moving to new tools to build packages