pike: Running tripleo-upgrade at normal job

[Quique Llorente]

http://logs.openstack.org/48/602248/23/check/tripleo-ci-centos-7-containers-multinode/141c28f/job-output.txt.gz#_2019-02-04_09_51_50_883398
2019-02-04 09:46:39.446397 | primary |
2019-02-04 09:46:39.446766 | primary | TASK [overcloud-prep-containers : Prepare for the containerized deployment] ****
2019-02-04 09:46:39.473224 | primary | Monday 04 February 2019 09:46:39 +0000 (0:00:03.628) 1:30:25.101 *******
2019-02-04 09:51:50.487551 | primary | changed: [undercloud]
2019-02-04 09:51:50.560471 | primary |
2019-02-04 09:51:50.560874 | primary | PLAY [Run tripleo-upgrade role to upgrade overcloud] ***************************
2019-02-04 09:51:50.786751 | primary |
2019-02-04 09:51:50.786948 | primary | TASK [tripleo-upgrade : create composable upgrade scripts] *********************
2019-02-04 09:51:50.808090 | primary | Monday 04 February 2019 09:51:50 +0000 (0:05:11.334) 1:35:36.436 *******
2019-02-04 09:51:50.842968 | primary | [DEPRECATION WARNING]: Using tests as filters is deprecated. Instead of using
2019-02-04 09:51:50.843182 | primary | `result|exists` instead use `result is exists`. This feature will be removed in
2019-02-04 09:51:50.843298 | primary | version 2.9. Deprecation warnings can be disabled by setting
2019-02-04 09:51:50.843382 | primary | deprecation_warnings=False in ansible.cfg.
2019-02-04 09:51:50.866886 | primary | [WARNING]: Unable to find '/home/zuul/repo-setup-pike.sh' in expected paths
2019-02-04 09:51:50.866988 | primary | (use -vvvvv to see paths)
2019-02-04 09:51:50.881026 | primary | fatal: [undercloud]: FAILED! => {}
2019-02-04 09:51:50.881096 | primary |
2019-02-04 09:51:50.881138 | primary | MSG:
2019-02-04 09:51:50.881168 | primary |
2019-02-04 09:51:50.883398 | primary | An unhandled exception occurred while templating '{{ (repo_setup_script|exists) | ternary(lookup('file', repo_setup_script), false) }}'. Error was a <class 'ansible.errors.AnsibleError'>, original message: An unhandled exception occurred while running the lookup plugin 'file'. Error was a <class 'ansible.errors.AnsibleError'>, original message: could not locate file in lookup: /home/zuul/repo-setup-pike.sh
2019-02-04 09

[Jose Luis Franco (jfrancoa)]

So, the problem occurs in this task:

  vars:
    repo_setup_script: "{{ working_dir }}/repo-setup-{{ release }}.sh"
  roles:
    - role: tripleo-upgrade
upgrade_init_command: "{{ (repo_setup_script|exists) | ternary(lookup('file', repo_setup_script), false) }}"

https://github.com/openstack/tripleo-quickstart-extras/blob/master/playbooks/multinode-overcloud-upgrade.yml#L50 , as repo_setup_script (being /home/stack/repo-setup-pike.sh doesn't exist because the taks that creates it (https://github.com/openstack/tripleo-quickstart-extras/blob/master/playbooks/multinode-overcloud-upgrade.yml#L9) didn't run, it fails. This wasn't a problem before because we were using the target_upgrade_version (https://review.openstack.org/#/c/607525/11/playbooks/multinode-overcloud-upgrade.yml), which in this job wasn't defined. I'll look for some way to bypass this issue.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/634724

[Quique Llorente (quiquell)]

There something werid, the override_branch version of the job is passing without the review
http://logs.openstack.org/45/560445/239/check/tripleo-ci-centos-7-containers-multinode-pike/cedc2ec/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/634883

[Quique Llorente (quiquell)]

Looks like we were using wrong branch for branchfull jobs
https://review.openstack.org/#/c/634917/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/634724
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=e6cfcb29f5087017f1c6e90daec62d80ed1991d3
Submitter: Zuul
Branch: master

commit e6cfcb29f5087017f1c6e90daec62d80ed1991d3
Author: Jose Luis Franco Arza <email address hidden>
Date: Mon Feb 4 16:48:35 2019 +0100

    Remove use of upgrade_init_command from multinode-overcloud-upgrade.yml.

    The UpgradeInitCommand heat resource hasn't work for some releases, even
    thought it has been recovered in [0] it added some complexity to the way
    we were invoking tripleo-upgrade role, as we needed to load into the
    upgrade_init_command variable the whole content of the script we wanted
    to run to switch repos. For that reason it's better to relay on repo-setup
    role to leave the repositories switched (without packages update) prior to
    invoking tripleo-upgrade as it is done in the undercloud upgrade playbook.

    Also, as tripleo-upgrade is now being imported by zuul, there is no need
    to call dynamically to tripleo-upgrade as before, we can use include_role
    instead.

    Co-Authored By: Quique Llorente <email address hidden>
    [0] - 9164e6adbdce69a2b7c10e1aea6c5cb309b6754e

    Change-Id: Ib35a971a4a4123933fb0d59c56655892fbd067a3
    Closes-Bug: #1814531

[OpenStack Infra (hudson-openstack)]

Change abandoned by Quique Llorente (<email address hidden>) on branch: master
Review: https://review.openstack.org/634883

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.