Deault 10s timeout for docker/podman stop is not enough for heat engine

[Rabi Mishra]

By default docker/podman stop/restart has a timeout (Seconds to wait for stop before killing the container) of 10s which is normally not enough for heat engines and would kill the engine workers abruptly. This may result in dead engines in the database as it's not a graceful stop.

Paunch has an option 'stop_grace_period' that can be used to set something more reasonable. This was added in paunch 3.1.0.

[Bogdan Dobrelya (bogdando)]

Right, we could adjust that stop_grace_period for heat_engine container in tht

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/633864

[Rabi Mishra (rabi)]

I'm not sure if this can be backported to queens as stop_grace_period is only available in paunch >=3.1.0. However, we can surely backport it to stable/rocky:)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/633864
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c618b21688699dbfe0668b81c6e12ab5a242be2f
Submitter: Zuul
Branch: master

commit c618b21688699dbfe0668b81c6e12ab5a242be2f
Author: Rabi Mishra <email address hidden>
Date: Wed Jan 30 09:00:10 2019 +0530

    Add stop_grace_period for heat_engine container

    Heat engine requires longer shutdown time for cleanup. The default
    10s is not enough. Let's increase it to something reasonable.

    Change-Id: Ie80112d75a74b1a9d1d497edcfcda8dba3de5345
    Closes-Bug: #1813771

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/634370

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/634370
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=85c419f83b72289b994adb8db3f2a5ede7a98819
Submitter: Zuul
Branch: stable/rocky

commit 85c419f83b72289b994adb8db3f2a5ede7a98819
Author: Rabi Mishra <email address hidden>
Date: Wed Jan 30 09:00:10 2019 +0530

    Add stop_grace_period for heat_engine container

    Heat engine requires longer shutdown time for cleanup. The default
    10s is not enough. Let's increase it to something reasonable.

    Change-Id: Ie80112d75a74b1a9d1d497edcfcda8dba3de5345
    Closes-Bug: #1813771
    (cherry picked from commit c618b21688699dbfe0668b81c6e12ab5a242be2f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.3.0 release.