keepalived container fails to configure correctly with facter 3

[Alex Schultz]

The interface_for_ip function assumes facter 2 syntax for facts but under fedora 28 we end up with a newer facter that no longer provides the interface_<interface> facts.

This results in the keepalived container failing to start because the 'interface' config line doesn't have an interface configured.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/632591

[Bogdan Dobrelya (bogdando)]

sigh, is it yey the time to abandon KA for the unified pacemaker tool used for single node and multi node?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/632591
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=5fff984cecf68c256e60ba6017f37b9d1e76e31b
Submitter: Zuul
Branch: master

commit 5fff984cecf68c256e60ba6017f37b9d1e76e31b
Author: Alex Schultz <email address hidden>
Date: Tue Jan 22 17:37:29 2019 -0700

    Fix interface_for_ip for newer facter versions

    In facter 3.x, the networking facts are in a complex hash. Previously
    the interface facts where flat so we would lookup the vars. This change
    first tries the facter 2.x lookup before falling back to the facter 3.x
    syntax.

    Change-Id: I260b18ae3479da4f5176027d4b26b3e1c6b22063
    Closes-Bug: #1812938

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 10.3.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/669702

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/669704

[Alfredo Moralejo (amoralej)]

For the record, this issue only affects to ovb iiuc, would it be worthy to add ovb job to rdoinfo promotion pipelines at least in experimental?

[Alex Schultz (alex-schultz)]

wouldn't hurt but this should have shown up on any job because it affected the undercloud

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/669704
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=db8d7cbe7ce42c0fafafc70c35dd5d9a611802ce
Submitter: Zuul
Branch: stable/queens

commit db8d7cbe7ce42c0fafafc70c35dd5d9a611802ce
Author: Alex Schultz <email address hidden>
Date: Tue Jan 22 17:37:29 2019 -0700

    Fix interface_for_ip for newer facter versions

    In facter 3.x, the networking facts are in a complex hash. Previously
    the interface facts where flat so we would lookup the vars. This change
    first tries the facter 2.x lookup before falling back to the facter 3.x
    syntax.

    Change-Id: I260b18ae3479da4f5176027d4b26b3e1c6b22063
    Closes-Bug: #1812938
    (cherry picked from commit 5fff984cecf68c256e60ba6017f37b9d1e76e31b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/669702
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=5eb012b4f62615519707a926cc62528f5dc54a44
Submitter: Zuul
Branch: stable/rocky

commit 5eb012b4f62615519707a926cc62528f5dc54a44
Author: Alex Schultz <email address hidden>
Date: Tue Jan 22 17:37:29 2019 -0700

    Fix interface_for_ip for newer facter versions

    In facter 3.x, the networking facts are in a complex hash. Previously
    the interface facts where flat so we would lookup the vars. This change
    first tries the facter 2.x lookup before falling back to the facter 3.x
    syntax.

    Closes-Bug: #1835718
    Change-Id: I260b18ae3479da4f5176027d4b26b3e1c6b22063
    Closes-Bug: #1812938
    (cherry picked from commit 5fff984cecf68c256e60ba6017f37b9d1e76e31b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 9.5.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.5.1 release.