Unused Jinja code in environments/network-isolation*.j2.yaml

Bug #1808893 reported by Harald Jensås on 2018-12-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Low
Harald Jensås

Bug Description

The jinja code at the top of network-isolation is no longer used since the RedisVipPort resource was removed due to duplication in f543752da6e1df3537ffa68d86806e11ac380375.

{%- set primary_role = [roles[0]] -%}
{%- for role in roles -%}
  {%- if 'primary' in role.tags and 'controller' in role.tags -%}
    {%- set _ = primary_role.pop() -%}
    {%- set _ = primary_role.append(role) -%}
  {%- endif -%}
{%- endfor -%}
{%- set primary_role_name = primary_role[0].name -%}

Fix proposed to branch: master
Review: https://review.openstack.org/625748

Changed in tripleo:
status: Triaged → In Progress
Changed in tripleo:
milestone: stein-2 → stein-3

Reviewed: https://review.openstack.org/625748
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2e36a4cfe9f413cb71cf8af3f9eb23df17a29912
Submitter: Zuul
Branch: master

commit 2e36a4cfe9f413cb71cf8af3f9eb23df17a29912
Author: Harald Jensås <email address hidden>
Date: Tue Dec 18 02:22:31 2018 +0100

    Remove unused jinja code in network-isolation environment

    Change I222873859af1b4ed1050cfffe55687b2f8d4c528 removed the
    RedisVipPort using the {{primary_role_name}} jinja varialble.
    The code to get the primary_role_name is no longer necessary.

    Closes-Bug: #1808893
    Change-Id: Id416786c85a48c598ccc8a9975bb07d7735df218

Changed in tripleo:
status: In Progress → Fix Released

This issue was fixed in the openstack/tripleo-heat-templates 10.4.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers