TLS everywhere deployments fail with: Invalid input for field/attribute compact_services

[Raildo Mascena de Sousa Filho]

During oooq deployments with tls-everywhere enabled fails on overcloud deploy stage with:

overcloud.Controller.1.Controller:
  resource_type: OS::TripleO::ControllerServer
  physical_resource_id:
  status: CREATE_FAILED
  status_reason: |
    BadRequest: resources.Controller: Invalid input for field/attribute compact_services. Value: {"ovs": ["internalapi"], "HTTP": ["ctlplane", "storage", "storagemgmt", "internalapi", "external", "management"], "libvirt-vnc": ["internalapi"], "rabbitmq": ["internalapi"], "odl": ["internalapi"], "mysql": ["internalapi"], "novnc-proxy": ["internalapi"], "neutron": ["internalapi"]}. u'{"ovs": ["internalapi"], "HTTP": ["ctlplane", "storage", "storagemgmt", "internalapi", "external", "management"], "libvirt-vnc": ["internalapi"], "rabbitmq": ["internalapi"], "odl": ["internalapi"], "mysql": ["internalapi"], "novnc-proxy": ["internalapi"], "neutron": ["internalapi"]}' is too long (HTTP 400) (Request-ID: req-f5c8b045-5c74-40-ad28-5abf22b2fad3)
overcloud.Controller.0.Controller:
  resource_type: OS::TripleO::ControllerServer
  physical_resource_id:
  status: CREATE_FAILED
  status_reason: |
    BadRequest: resources.Controller: Invalid input for field/attribute compact_services. Value: {"ovs": ["internalapi"], "HTTP": ["ctlplane", "storage", "storagemgmt", "internalapi", "external", "management"], "libvirt-vnc": ["internalapi"], "rabbitmq": ["internalapi"], "odl": ["internalapi"], "mysql": ["internalapi"], "novnc-proxy": ["internalapi"], "neutron": ["internalapi"]}. u'{"ovs": ["internalapi"], "HTTP": ["ctlplane", "storage", "storagemgmt", "internalapi", "external", "management"], "libvirt-vnc": ["internalapi"], "rabbitmq": ["internalapi"], "odl": ["internalapi"], "mysql": ["internalapi"], "novnc-proxy": ["internalapi"], "neutron": ["internalapi"]}' is too long (HTTP 400) (Request-ID: req-8e7ed022-26a9-47a1-9ddb-05141e7)
overcloud.Controller.2.Controller:
  resource_type: OS::TripleO::ControllerServer
  physical_resource_id:
  status: CREATE_FAILED
  status_reason: |
    BadRequest: resources.Controller: Invalid input for field/attribute compact_services. Value: {"ovs": ["internalapi"], "HTTP": ["ctlplane", "storage", "storagemgmt", "internalapi", "external", "management"], "libvirt-vnc": ["internalapi"], "rabbitmq": ["internalapi"], "odl": ["internalapi"], "mysql": ["internalapi"], "novnc-proxy": ["internalapi"], "neutron": ["internalapi"]}. u'{"ovs": ["internalapi"], "HTTP": ["ctlplane", "storage", "storagemgmt", "internalapi", "external", "management"], "libvirt-vnc": ["internalapi"], "rabbitmq": ["internalapi"], "odl": ["internalapi"], "mysql": ["internalapi"], "novnc-proxy": ["internalapi"], "neutron": ["internalapi"]}' is too long (HTTP 400) (Request-ID: req-5ba54950-af61-4bcf-8fd9-ce3a7)

* In tripleo-heat-templates, we construct data to be passed to novajoin for all the services to be configured. The data is passed as nova metadata fields.
* There can be any number of these fields, but each field cannot exceed 256 bytes.
* In particular, the services on a controller not related to a VIP are passed in a field called "compact_services", we can exceed the 256 byte restriction.
* We see that happen in the log snippet above ...

[Raildo Mascena de Sousa Filho (raildo)]

Fixed on t-h-t master on: https://review.openstack.org/#/c/623316/

[Raildo Mascena de Sousa Filho (raildo)]

fixed on novajoin on: https://review.openstack.org/#/c/624502/

[Raildo Mascena de Sousa Filho (raildo)]

Rocky - Backport: https://review.openstack.org/625692

Queens - Backport: https://review.openstack.org/625693