Havin 'tag_from_label' at container prep parametes prevent execution

Bug #1808371 reported by Quique Llorente on 2018-12-13
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Quique Llorente

Bug Description

After fixing container prep for standalone jobs, we discover that if we have the 'tag_from_label' atribute with at the containers-prepare-parameters.yaml the tripleo-image-modify role is not executed.

Possible failure is here https://github.com/openstack/tripleo-common/blob/master/tripleo_common/image/kolla_builder.py#L298-L306

To reproduce this just run the tripleo container prep with the following yaml

arameter_defaults:
    ContainerImagePrepare:
    - modify_append_tag: -updated-20181212132010
        modify_only_with_labels:
        - kolla_version
        modify_role: tripleo-modify-image
        modify_vars:
            tasks_from: yum_update.yml
            update_repo: delorean-current
            yum_repos_dir_path: /etc/yum.repos.d
        push_destination: 192.168.24.1:8787
        set:
            ceph_image: daemon
            ceph_namespace: docker.io/ceph
            ceph_tag: v3.2.0-stable-3.2-luminous-centos-7-x86_64
            name_prefix: centos-binary-
            name_suffix: ''
            namespace: docker.io/tripleomaster
            neutron_driver: null
            openshift_cluster_monitoring_image: cluster-monitoring-operator
            openshift_cluster_monitoring_namespace: quay.io/coreos
            openshift_cluster_monitoring_tag: v0.1.1
            openshift_cockpit_image: kubernetes
            openshift_cockpit_namespace: docker.io/cockpit
            openshift_cockpit_tag: latest
            openshift_configmap_reload_image: configmap-reload
            openshift_configmap_reload_namespace: quay.io/coreos
            openshift_configmap_reload_tag: latest
            openshift_etcd_image: etcd
            openshift_etcd_namespace: registry.fedoraproject.org/latest
            openshift_etcd_tag: latest
            openshift_gluster_block_image: glusterblock-provisioner
            openshift_gluster_image: gluster-centos
            openshift_gluster_namespace: docker.io/gluster
            openshift_gluster_tag: latest
            openshift_grafana_namespace: docker.io/grafana
            openshift_grafana_tag: latest
            openshift_heketi_image: heketi
            openshift_heketi_namespace: docker.io/heketi
            openshift_heketi_tag: latest
            openshift_kube_rbac_proxy_image: kube-rbac-proxy
            openshift_kube_rbac_proxy_namespace: quay.io/coreos
            openshift_kube_rbac_proxy_tag: v0.3.1
            openshift_kube_state_metrics_image: kube-state-metrics
            openshift_kube_state_metrics_namespace: quay.io/coreos
            openshift_kube_state_metrics_tag: latest
            openshift_namespace: docker.io/openshift
            openshift_oauth_proxy_tag: latest
            openshift_prefix: origin
            openshift_prometheus_alertmanager_tag: latest
            openshift_prometheus_config_reload_image: prometheus-config-reloader
            openshift_prometheus_config_reload_namespace: quay.io/coreos
            openshift_prometheus_config_reload_tag: v0.24.0
            openshift_prometheus_node_exporter_tag: latest
            openshift_prometheus_operator_image: prometheus-operator
            openshift_prometheus_operator_namespace: quay.io/coreos
            openshift_prometheus_operator_tag: latest
            openshift_prometheus_tag: latest
            openshift_tag: v3.11.0
            tag: current-tripleo
        tag_from_label: rdo_version
    DockerInsecureRegistryAddress:
    - 192.168.24.1:8787

description: updated
description: updated

Is this still an issue?

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers