Tripleo deployment of openshift should rely on openshift-ansible defaults as much as possible

Bug #1806726 reported by Martin André on 2018-12-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Martin André

Bug Description

There are a few openshift-ansible settings in our tripleo heat templates that have nothing to do here. We should rely on openshift-ansible defaults as much as possible.

https://github.com/openstack/tripleo-heat-templates/blob/d295cd9/extraconfig/services/openshift-master.yaml#L171-L183

Fix proposed to branch: master
Review: https://review.openstack.org/622440

Changed in tripleo:
status: Triaged → In Progress
Changed in tripleo:
milestone: stein-2 → stein-3

Reviewed: https://review.openstack.org/622440
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3e613f1788dead339f3d40df64ea959323ae2848
Submitter: Zuul
Branch: master

commit 3e613f1788dead339f3d40df64ea959323ae2848
Author: Martin André <email address hidden>
Date: Tue Dec 4 17:47:44 2018 +0100

    Remove openshift-ansible customization

    This commit remove variables passed to openshift-ansible in order to
    stay more inline with openshift-ansible defaults.

    The removed variables are:
    - `openshift_enable_excluders`: use default value from
      openshift-ansible.
    - `openshift_use_dnsmasq`: removed from openshift-ansible.
    - `openshift_docker_selinux_enabled`: use default value from
      openshift-ansible.
    - `containerized`: removed from openshift-ansible.
    - `skip_version`: removed from openshift-ansible.
    - `debug_level`: use default value from openshift-ansible.
    - `osm_controller_args`: use default value from openshift-ansible. The
      provided experimental-cluster-signing-duration setting had an
      extremely low period and could cause nodes to become unreachable in
      the event of cert renewal during the master node failover. See [1] for
      details.

    [1] https://bugzilla.redhat.com/show_bug.cgi?id=1648493

    Closes-Bug: #1806726
    Change-Id: I4d9ae4f4745393aa817f07a542f06faa0c6a5eb9

Changed in tripleo:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/631715
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=bda0c48e694e8f36cff48bd7cc90ddbe017d17b6
Submitter: Zuul
Branch: stable/rocky

commit bda0c48e694e8f36cff48bd7cc90ddbe017d17b6
Author: Martin André <email address hidden>
Date: Tue Dec 4 17:47:44 2018 +0100

    Remove openshift-ansible customization

    This commit remove variables passed to openshift-ansible in order to
    stay more inline with openshift-ansible defaults.

    The removed variables are:
    - `openshift_enable_excluders`: use default value from
      openshift-ansible.
    - `openshift_use_dnsmasq`: removed from openshift-ansible.
    - `openshift_docker_selinux_enabled`: use default value from
      openshift-ansible.
    - `containerized`: removed from openshift-ansible.
    - `skip_version`: removed from openshift-ansible.
    - `debug_level`: use default value from openshift-ansible.
    - `osm_controller_args`: use default value from openshift-ansible. The
      provided experimental-cluster-signing-duration setting had an
      extremely low period and could cause nodes to become unreachable in
      the event of cert renewal during the master node failover. See [1] for
      details.

    [1] https://bugzilla.redhat.com/show_bug.cgi?id=1648493

    Closes-Bug: #1806726
    Change-Id: I4d9ae4f4745393aa817f07a542f06faa0c6a5eb9
    (cherry picked from commit 3e613f1788dead339f3d40df64ea959323ae2848)

tags: added: in-stable-rocky

This issue was fixed in the openstack/tripleo-heat-templates 10.4.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.