rabbitmq bundle logs excessively

[Michele Baldessari]

rabbitmq bundle logs too many lines for every pacemaker monitoring operation.
Namely we log:
1) su:pam_systemd(su:session): Failed to connect to system bus: No such file or
directory
2) Oct 23 13:52:52 overcloud-controller-0 su: pam_unix(su:session): session opened for user rabbitmq by (uid=0)
Oct 23 13:52:54 overcloud-controller-0 su: pam_unix(su:session): session closed for user rabbitmq
3) Dec 03 12:56:28 controller-0 rabbitmq-cluster(rabbitmq)[244556]: DEBUG: RabbitMQ server is running normally

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/621660

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/621661

[Michele Baldessari (michele)]

3) Will be taken care of by https://github.com/ClusterLabs/resource-agents/pull/1272 and https://bugzilla.redhat.com/show_bug.cgi?id=1655655

There will still be a 4) message:
Dec 03 12:56:27 controller-0 su[244232]: (to rabbitmq) root on none

4) is harder to get rid of as that message is hardcoded in the 'su' util

[Keigo Noha (knoha)]

Hello Michele,

Thank you for your work on this launchpad.
In your description, I can't find what is the message corresponding to No.4 in c#3.
Do you intend No.1?

Best Regards,
Keigo Noha

[Michele Baldessari (michele)]

No i don't intend n1. I wrote the message and tagged it with 4) in my comment#3:
"""
There will still be a 4) message:
Dec 03 12:56:27 controller-0 su[244232]: (to rabbitmq) root on none
"""

[Keigo Noha (knoha)]

Hello Michele,

Thank you for your clarification. I think the message in No.4 is can't be suppressed because su util generates the messages every execution and su command is used in rabbitmqctl.
The similar messages to No.4 are observed in usual operation.

However, No.1 look like an error or warning to users.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/621660
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=34aa23814ed80be7202ae8d92bdae08ad640f861
Submitter: Zuul
Branch: master

commit 34aa23814ed80be7202ae8d92bdae08ad640f861
Author: Michele Baldessari <email address hidden>
Date: Mon Dec 3 18:37:38 2018 +0100

    puppet_config for rabbitmq_bundle needs file_line

    The main reason for this change is that in a related puppet-tripleo patch
    we will use the file_line puppet class in order to set some parameters
    to reduce the excessive rabbitmq logging.

    Because this change will be very specific to rabbitmq running in a
    container we also need to make sure that we actually use the
    rabbitmq_bundle puppet manifest to create config files and not the
    more generic one.

    Change-Id: Ic0789da4645a4ee186d82ad7d943de78d4d5c443
    Related-Bug: #1806451

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/621661
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=44985bd42d21ce705387c01b188f27711791f51f
Submitter: Zuul
Branch: master

commit 44985bd42d21ce705387c01b188f27711791f51f
Author: Michele Baldessari <email address hidden>
Date: Mon Dec 3 18:43:38 2018 +0100

    Remove some of the excessive rabbitmq bundle logging

    By removing the pam-systemd optinal session line we get rid of the
    following line:
    pam_systemd(su:session): Failed to connect to system bus: No such file or directory

    It is useless inside a container anyway since the pam_systemd module
    registers user sessions.

    By adding a sufficient pam_succeed_if call fo when the user belongs to the
    rabbitmq group we get rid of the following spurious log:
    Oct 23 13:52:52 overcloud-controller-0 su: pam_unix(su:session): session opened for user rabbitmq by (uid=0)
    Oct 23 13:52:54 overcloud-controller-0 su: pam_unix(su:session): session closed for user rabbitmq

    We do not need this inside a container anyway. In the future (w/
    pam_unix 1.2.0 and onwards we will be able to use the quiet option
    instead).

    Depends-On: Ic0789da4645a4ee186d82ad7d943de78d4d5c443

    Change-Id: Icd199ca4ce4848c971488d8ab69e668add86b150
    Related-Bug: #1806451

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.openstack.org/626595

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.openstack.org/626597

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/626595
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f750ab67ead3692145c7bf78f77edc96bf0cc97d
Submitter: Zuul
Branch: stable/rocky

commit f750ab67ead3692145c7bf78f77edc96bf0cc97d
Author: Michele Baldessari <email address hidden>
Date: Mon Dec 3 18:37:38 2018 +0100

    puppet_config for rabbitmq_bundle needs file_line

    The main reason for this change is that in a related puppet-tripleo patch
    we will use the file_line puppet class in order to set some parameters
    to reduce the excessive rabbitmq logging.

    Because this change will be very specific to rabbitmq running in a
    container we also need to make sure that we actually use the
    rabbitmq_bundle puppet manifest to create config files and not the
    more generic one.

    Change-Id: Ic0789da4645a4ee186d82ad7d943de78d4d5c443
    Related-Bug: #1806451
    (cherry picked from commit 34aa23814ed80be7202ae8d92bdae08ad640f861)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/626597
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=608096fb3ce3cf291550278c39be3b0562bd18eb
Submitter: Zuul
Branch: stable/rocky

commit 608096fb3ce3cf291550278c39be3b0562bd18eb
Author: Michele Baldessari <email address hidden>
Date: Mon Dec 3 18:43:38 2018 +0100

    Remove some of the excessive rabbitmq bundle logging

    By removing the pam-systemd optinal session line we get rid of the
    following line:
    pam_systemd(su:session): Failed to connect to system bus: No such file or directory

    It is useless inside a container anyway since the pam_systemd module
    registers user sessions.

    By adding a sufficient pam_succeed_if call fo when the user belongs to the
    rabbitmq group we get rid of the following spurious log:
    Oct 23 13:52:52 overcloud-controller-0 su: pam_unix(su:session): session opened for user rabbitmq by (uid=0)
    Oct 23 13:52:54 overcloud-controller-0 su: pam_unix(su:session): session closed for user rabbitmq

    We do not need this inside a container anyway. In the future (w/
    pam_unix 1.2.0 and onwards we will be able to use the quiet option
    instead).

    NB: cherry-pick not %100 clean due to slightly changed diff context

    Depends-On: Ic0789da4645a4ee186d82ad7d943de78d4d5c443

    Change-Id: Icd199ca4ce4848c971488d8ab69e668add86b150
    Related-Bug: #1806451
    (cherry picked from commit 44985bd42d21ce705387c01b188f27711791f51f)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/629199

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/629200

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/629199
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a9d337396f8ccd60192c09dfb1b352afe9585cb1
Submitter: Zuul
Branch: stable/queens

commit a9d337396f8ccd60192c09dfb1b352afe9585cb1
Author: Michele Baldessari <email address hidden>
Date: Mon Dec 3 18:37:38 2018 +0100

    puppet_config for rabbitmq_bundle needs file_line

    The main reason for this change is that in a related puppet-tripleo patch
    we will use the file_line puppet class in order to set some parameters
    to reduce the excessive rabbitmq logging.

    Because this change will be very specific to rabbitmq running in a
    container we also need to make sure that we actually use the
    rabbitmq_bundle puppet manifest to create config files and not the
    more generic one.

    Change-Id: Ic0789da4645a4ee186d82ad7d943de78d4d5c443
    Related-Bug: #1806451
    (cherry picked from commit 34aa23814ed80be7202ae8d92bdae08ad640f861)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/629200
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=5bb0a71c65d5f35e0945e93ddc0ce273da12fbe4
Submitter: Zuul
Branch: stable/queens

commit 5bb0a71c65d5f35e0945e93ddc0ce273da12fbe4
Author: Michele Baldessari <email address hidden>
Date: Mon Dec 3 18:43:38 2018 +0100

    Remove some of the excessive rabbitmq bundle logging

    By removing the pam-systemd optinal session line we get rid of the
    following line:
    pam_systemd(su:session): Failed to connect to system bus: No such file or directory

    It is useless inside a container anyway since the pam_systemd module
    registers user sessions.

    By adding a sufficient pam_succeed_if call fo when the user belongs to the
    rabbitmq group we get rid of the following spurious log:
    Oct 23 13:52:52 overcloud-controller-0 su: pam_unix(su:session): session opened for user rabbitmq by (uid=0)
    Oct 23 13:52:54 overcloud-controller-0 su: pam_unix(su:session): session closed for user rabbitmq

    We do not need this inside a container anyway. In the future (w/
    pam_unix 1.2.0 and onwards we will be able to use the quiet option
    instead).

    Depends-On: Ic0789da4645a4ee186d82ad7d943de78d4d5c443

    Change-Id: Icd199ca4ce4848c971488d8ab69e668add86b150
    Related-Bug: #1806451
    (cherry picked from commit 44985bd42d21ce705387c01b188f27711791f51f)