tripleo_undercloud_conf_file hiera variable is missing after the instack-undercloud retirement

[Gael Chamoulaud]

Tripleo-validations is relying on the 'tripleo_undercloud_conf_file' hiera variable which gives us the path of the undercloud.conf file. With the retirement of instack-undercloud, this hiera variable is not present anymore. It looks like a regression.

Sofer already started on fixing the bug, https://review.openstack.org/#/c/614470/

[Dan Prince (dan-prince)]

What if we created an 'Undercloud' service and set it via t-h-t hiera hooks. The fact is the Undercloud still generates and consumes hiera. That way thus preserving the previous (unknown to some of us) behavior.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/622372
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=c1ad985618073a1be9978187a0f1d5e3aa26999f
Submitter: Zuul
Branch: master

commit c1ad985618073a1be9978187a0f1d5e3aa26999f
Author: Emilien Macchi <email address hidden>
Date: Tue Dec 4 10:44:02 2018 -0500

    undercloud: enable undercloud_config parameter for validations

    If TripleO Validations are enabled, we want to export UndercloudConfigFilePath
    so the validations can work from the Mistral Executor container.

    UndercloudConfigFilePath is set even if the preflight validations runs
    are ommitted (when using the --no-validations option).

    These parameters will be used in THT to feed hieradata and also bind
    mount the undercloud configuration file.

    Change-Id: I38f6d562ab452f765672e7cc4e71206b562c471b
    Related-Bug: #1805825

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.openstack.org/624323

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/624323
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=247c4be23166ba7aa9261d5616c276e6ddacb0df
Submitter: Zuul
Branch: stable/rocky

commit 247c4be23166ba7aa9261d5616c276e6ddacb0df
Author: Emilien Macchi <email address hidden>
Date: Tue Dec 4 10:44:02 2018 -0500

    undercloud: enable undercloud_config parameter for validations

    If TripleO Validations are enabled, we want to export UndercloudConfigFilePath
    so the validations can work from the Mistral Executor container.

    UndercloudConfigFilePath is set even if the preflight validations runs
    are ommitted (when using the --no-validations option).

    These parameters will be used in THT to feed hieradata and also bind
    mount the undercloud configuration file.

    Change-Id: I38f6d562ab452f765672e7cc4e71206b562c471b
    Related-Bug: #1805825
    (cherry picked from commit c1ad985618073a1be9978187a0f1d5e3aa26999f)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/614470
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=bcb079af86304e162a6d29dd0f1fd384fcbe4883
Submitter: Zuul
Branch: master

commit bcb079af86304e162a6d29dd0f1fd384fcbe4883
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Oct 31 12:26:58 2018 +0100

    mistral-executor: bind-mount undercloud.conf when validations are enabled

    When validations are enabled, let's:

    - Bind mount undercloud.conf using UndercloudConfigFilePath generated by
      tripleoclient and mount it to mistral-executor into
      /var/lib/mistral/undercloud.conf in raed-only mode.
    - Export tripleo_undercloud_conf_file hieradata, needed by Ansible when
      looking for the the Undercloud config file path.
      Note: it could be improved in the future by not relying on Hiera
      anymore and using an Ansible variable that we would export into the
      container.

    Closes-Bug: #1805825

    Co-Authored-By: Sofer Athlan-Guyot <email address hidden>
    Co-Authored-By: Emilien Macchi <email address hidden>
    Co-Authored-By: Gael Chamoulaud <email address hidden>
    Co-Authored-By: Florian Fuchs <email address hidden>

    Depends-On: I38f6d562ab452f765672e7cc4e71206b562c471b

    Change-Id: Id947ad7efc96c4657f7b0a0fec4c0036e0044d0e

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/624623

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/624623
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=09daf69622d560bb0c349e65e63c75c1c6aff108
Submitter: Zuul
Branch: stable/rocky

commit 09daf69622d560bb0c349e65e63c75c1c6aff108
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Oct 31 12:26:58 2018 +0100

    mistral-executor: bind-mount undercloud.conf when validations are enabled

    When validations are enabled, let's:

    - Bind mount undercloud.conf using UndercloudConfigFilePath generated by
      tripleoclient and mount it to mistral-executor into
      /var/lib/mistral/undercloud.conf in raed-only mode.
    - Export tripleo_undercloud_conf_file hieradata, needed by Ansible when
      looking for the the Undercloud config file path.
      Note: it could be improved in the future by not relying on Hiera
      anymore and using an Ansible variable that we would export into the
      container.

    Closes-Bug: #1805825

    Co-Authored-By: Sofer Athlan-Guyot <email address hidden>
    Co-Authored-By: Emilien Macchi <email address hidden>
    Co-Authored-By: Gael Chamoulaud <email address hidden>
    Co-Authored-By: Florian Fuchs <email address hidden>

    Depends-On: I38f6d562ab452f765672e7cc4e71206b562c471b

    Change-Id: Id947ad7efc96c4657f7b0a0fec4c0036e0044d0e
    (cherry picked from commit bcb079af86304e162a6d29dd0f1fd384fcbe4883)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.3.0 release.