UpdateParametersAction is doing too much in case of errors

Bug #1805439 reported by Thomas Herve on 2018-11-27
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Medium
Thomas Herve

Bug Description

When template validation fails, we call ProcessTemplatesAction.run all over again. But we don't need to data generated, we only need to update what's in swift, so we can be more restrictive on what we call.

Thomas Herve (therve) on 2018-11-27
Changed in tripleo:
importance: Undecided → Medium
assignee: nobody → Thomas Herve (therve)
milestone: none → stein-3

Fix proposed to branch: master
Review: https://review.openstack.org/620319

Changed in tripleo:
status: New → In Progress

Reviewed: https://review.openstack.org/620319
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=8bfa3517a45dded6faac0a6a856cf932d2982360
Submitter: Zuul
Branch: master

commit 8bfa3517a45dded6faac0a6a856cf932d2982360
Author: Thomas Herve <email address hidden>
Date: Tue Nov 27 15:07:04 2018 +0100

    Don't upcall run on UpdateParametersAction errors

    When template validation fails, we don't need to call
    ProcessTemplatesAction.run all over again, we can just call
    _process_custom_roles which will take care of regenerating the env
    properly.

    Change-Id: Id7e0c7df7b63645058b8ecb1efcae186678fcb7c
    Closes-Bug: #1805439

Changed in tripleo:
status: In Progress → Fix Released

This issue was fixed in the openstack/tripleo-common 10.2.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers