bad chronyd configuration prevents chronyd from starting during deployment

[Brent Eagles]

Looks like a problem with the chrony.conf.j2 template. /etc/chrony.conf does not start when configured during deployment

Nov 19 20:43:23 overcloud-controller-0 systemd: Stopping NTP client/server...
Nov 19 20:43:23 overcloud-controller-0 chronyd[645]: chronyd exiting
Nov 19 20:43:23 overcloud-controller-0 systemd: Starting NTP client/server...
Nov 19 20:43:23 overcloud-controller-0 chronyd[16234]: chronyd version 3.2 starting (+CMDMON +NTP +REFCLOCK +RTC +PRIVDROP +SCFILTER +SECHASH +SIGND +ASYNCDNS +IPV6 +DEBUG)
Nov 19 20:43:23 overcloud-controller-0 chronyd[16234]: Fatal error : Invalid command at line 10 in file /etc/chrony.conf
Nov 19 20:43:23 overcloud-controller-0 chronyd: Invalid command at line 10 in file /etc/chrony.conf
Nov 19 20:43:23 overcloud-controller-0 systemd: chronyd.service: control process exited, code=exited status=1
Nov 19 20:43:23 overcloud-controller-0 systemd: Failed to start NTP client/server.
Nov 19 20:43:23 overcloud-controller-0 systemd: Unit chronyd.service entered failed state.
Nov 19 20:43:23 overcloud-controller-0 systemd: chronyd.service failed.

The generated config is:

# Do not manually edit this file.
# Managed by ansible-role-chrony
server 0.rhel.pool.ntp.org iburst
server 1.rhel.pool.ntp.org iburst
server 2.rhel.pool.ntp.org iburst
server 3.rhel.pool.ntp.org iburst
pool u'pool.ntp.org' iburst minpoll 6 maxpoll 10
bindcmdaddress 127.0.0.1
bindcmdaddress ::1
u'deny all' # <<--- line 10
driftfile /var/lib/chrony/drift
logdir /var/log/chrony
rtcsync
makestep 1.0 3

The "u'deny all' seems to be the culprit (the pool line is suspect as well). Changing this line to "deny all" allows the service to proceed.

[Emilien Macchi (emilienm)]

Fixed by https://review.openstack.org/#/c/614876/ . I think it's failing because we need a promotion.