Stop setting boot_option:local on flavors and nodes

[Derek Higgins]

This is now redundant as Ironic now defaults to local boot in TripleO and one day we'll have to migrate from using capabilities.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/618725

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/618727

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/618739

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/619034

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/619261

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/618725
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=ecc06e9cbcfb0e3085fb7cf3790ba36d0666402e
Submitter: Zuul
Branch: master

commit ecc06e9cbcfb0e3085fb7cf3790ba36d0666402e
Author: Derek Higgins <email address hidden>
Date: Mon Nov 19 10:28:20 2018 +0000

    Remove checks for boot_option

    Setting boot_option_local is no longer required as its the default.

    Remove the check on ironic nodes for this capability and change the
    warning message issued if capabilities:boot_option is set too
    netboot on flavors.

    Change-Id: I9fbe12f7878328f0ca084e29483f30d18dad1773
    Related-Bug: #1803965

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/618727
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3d9e7731b58db01ff62677ae3978ef3cbe155716
Submitter: Zuul
Branch: master

commit 3d9e7731b58db01ff62677ae3978ef3cbe155716
Author: Derek Higgins <email address hidden>
Date: Mon Nov 19 10:37:16 2018 +0000

    Don't set boot_option=local on baremetal flavors

    Setting boot_option_local is no longer required as its the default.
    So setting this is redundant.

    Migrate existing flavors to remove boot_option if set to local.

    Change-Id: Ib793acc98641091bcde2580b725656976e5d6625
    Depends-On: I9fbe12f7878328f0ca084e29483f30d18dad1773
    Related-Bug: #1803965

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/619034
Reason: Clearing the gate. Do not retore this until being given the all clear. See http://lists.openstack.org/pipermail/openstack-discuss/2018-November/000368.html

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/618739

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/618739
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=08b89e6c82b2539c59a72fe921545631e40a9594
Submitter: Zuul
Branch: master

commit 08b89e6c82b2539c59a72fe921545631e40a9594
Author: Derek Higgins <email address hidden>
Date: Mon Nov 19 11:53:55 2018 +0000

    Stop setting boot_option=local on ironic nodes

    This is now the default in ironic on tripleo and
    redundant.

    Change-Id: I249a1a9e30c06ea15b487e952b91949c606423c5
    Depends-On: Ib793acc98641091bcde2580b725656976e5d6625
    Related-Bug: #1803965

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619034
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=4b3fc8479f88b90ce542e4ea03d8a4c480bb230b
Submitter: Zuul
Branch: master

commit 4b3fc8479f88b90ce542e4ea03d8a4c480bb230b
Author: Derek Higgins <email address hidden>
Date: Tue Nov 20 16:25:35 2018 +0000

    Stop setting boot_option=local on ironic nodes

    This is now the default in ironic on tripleo and
    redundant.

    Change-Id: I4047298ac5af8a0314ace343518f695144073ff5
    Depends-On: I249a1a9e30c06ea15b487e952b91949c606423c5
    Related-Bug: #1803965

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/619261
Committed: https://git.openstack.org/cgit/openstack/tripleo-docs/commit/?id=2ad5c39ca2d40d62806266018f6c83174b1acc32
Submitter: Zuul
Branch: master

commit 2ad5c39ca2d40d62806266018f6c83174b1acc32
Author: Derek Higgins <email address hidden>
Date: Wed Nov 21 14:33:44 2018 +0000

    Remove redundant mentions of boot_option

    boot_option=local is now the default so no need to set it
    explicitly.

    Depends-On: I4047298ac5af8a0314ace343518f695144073ff5
    Change-Id: Ib3537d18cfab2e7d1513c528c2a43d9ed3041a59
    Related-Bug: #1803965