[master] tripleo-ci-centos-7-scenario007-multinode-oooq-container job failing at overcloud deploy with TemplateOutputError: Error in 44 output role_data: Incorrect arguments: Items to concat must be lists.

[chandan kumar]

/tripleo-ci-centos-7-scenario007-multinode-oooq-container job uses fs030 deploys ovn setup in multinode job. It is failing consistently on master against each patch set while overcloud deploy step.

below is the logs:
http://logs.openstack.org/45/560445/197/check/tripleo-ci-centos-7-scenario007-multinode-oooq-container/5b966f7/logs/undercloud/var/log/containers/heat/heat-engine.log.txt.gz#_2018-11-19_01_24_17_849

2018-11-19 01:24:17.849 30 INFO heat.engine.resource [req-f225f0c3-5208-4923-aafb-2b2f33e29c11 - admin - default default] CREATE: TemplateResource "ControllerServiceChain" [4a4db96a-7fa3-496f-82ad-8bc5c8862490] Stack "overcloud" [53dff2bf-fe54-4a6e-9d4d-c0e9e902e52d]
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource Traceback (most recent call last):
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource File "/usr/lib/python2.7/site-packages/heat/engine/resource.py", line 924, in _action_recorder
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource yield
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource File "/usr/lib/python2.7/site-packages/heat/engine/resource.py", line 1037, in _do_action
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource yield self.action_handler_task(action, args=handler_args)
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource File "/usr/lib/python2.7/site-packages/heat/engine/scheduler.py", line 346, in wrapper
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource step = next(subtask)
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource File "/usr/lib/python2.7/site-packages/heat/engine/resource.py", line 986, in action_handler_task
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource done = check(handler_data)
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource File "/usr/lib/python2.7/site-packages/heat/engine/resources/stack_resource.py", line 409, in check_create_complete
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource return self._check_status_complete(self.CREATE)
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource File "/usr/lib/python2.7/site-packages/heat/engine/resources/stack_resource.py", line 463, in _check_status_complete
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource action=action)
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource ResourceFailure: resources.ControllerServiceChain: Error in 16 output role_data: Incorrect arguments: Items to concat must be lists.
2018-11-19 01:24:17.849 30 ERROR heat.engine.resource

There might be something wrong the ControllerServiceChain template. it needs investigation.
It is a tracker bug.

Below is the other logs from the same job:
http://logs.openstack.org/97/617997/16/check/tripleo-ci-centos-7-scenario007-multinode-oooq-container/99ea4ac/logs/undercloud/var/log/containers/heat/heat-engine.log.txt.gz#_2018-11-18_23_48_43_950

http://logs.openstack.org/77/618477/6/check/tripleo-ci-centos-7-scenario007-multinode-oooq-container/14c43ea/logs/undercloud/var/log/containers/heat/heat-engine.log.txt.gz#_2018-11-18_18_18_30_811

[Daniel Alvarez (dalvarezs)]

Looks like this patch is the culprit: https://review.openstack.org/#/c/611801

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/618714

[chandan kumar (chkumar246)]

Also seen in periodic jobs https://logs.rdoproject.org/openstack-periodic/git.openstack.org/openstack-infra/tripleo-ci/master/periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset030-master/8806ce0/logs/undercloud/var/log/containers/heat/heat-engine.log.txt.gz#_2018-11-19_07_06_14_089

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/618714
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=36517c711610d24ae7767d451d855d64357d6883
Submitter: Zuul
Branch: master

commit 36517c711610d24ae7767d451d855d64357d6883
Author: Cédric Jeanneret <email address hidden>
Date: Mon Nov 19 10:18:32 2018 +0100

    Fix indentation issue

    Change Icde6c61a0b26741946d079b2b00475de34722bea introduced a couple of
    indentation mistakes.

    Change-Id: I47756939fd933788b85bbd141d3c3bd870445efa
    Closes-Bug: #1803949

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.2.0 release.