rotate_fernet_keys workflow fails with error

[Rabi Mishra]

rotate_fernet_keys workflow is still using heat software deployment and fails with error as config-download is the default from rocky and occ is disabled on overcloud nodes.

Steps to Reproduce:
1. run the key rotation command on the undercloud
(undercloud) [stack@undercloud-0 ~]$ openstack workflow execution create tripleo.fernet_keys.v1.rotate_fernet_keys '{"container": "overcloud"}'
+--------------------+-------------------------------------------+
| Field | Value |
+--------------------+-------------------------------------------+
| ID | b23a988a-6571-4fdb-b776-4897682f0ca0 |
| Workflow ID | f7b7db4a-0e85-409a-9d35-7b5f66698d0d |
| Workflow name | tripleo.fernet_keys.v1.rotate_fernet_keys |
| Workflow namespace | |
| Description | |
| Task Execution ID | <none> |
| Root Execution ID | <none> |
| State | RUNNING |
| State info | None |
| Created at | 2018-10-15 20:24:47 |
| Updated at | 2018-10-15 20:24:47 |
+--------------------+-------------------------------------------+

2. Wait for the task failures.
(undercloud) [stack@undercloud-0 ~]$ mistral task-list b23a988a-6571-4fdb-b776-4897682f0ca0
+--------------------------------------+----------------+-------------------------------------------+--------------------+--------------------------------------+---------+------------------------------+---------------------+---------------------+
| ID | Name | Workflow name | Workflow namespace | Workflow Execution ID | State | State info | Created at | Updated at |
+--------------------------------------+----------------+-------------------------------------------+--------------------+--------------------------------------+---------+------------------------------+---------------------+---------------------+
| 22f97f48-3fc7-425e-8e5e-224958f04e68 | rotate_keys | tripleo.fernet_keys.v1.rotate_fernet_keys | | b23a988a-6571-4fdb-b776-4897682f0ca0 | SUCCESS | None | 2018-10-15 20:24:47 | 2018-10-15 20:24:48 |
| 1697f654-17f3-4602-89d9-6c614bd739d9 | deploy_ssh_key | tripleo.fernet_keys.v1.rotate_fernet_keys | | b23a988a-6571-4fdb-b776-4897682f0ca0 | ERROR | Failure caused by error i... | 2018-10-15 20:24:48 | 2018-10-15 20:30:00 |
| 9266b23f-8252-44cd-8a96-3dd13c7c6cf8 | send_message | tripleo.fernet_keys.v1.rotate_fernet_keys | | b23a988a-6571-4fdb-b776-4897682f0ca0 | ERROR | Workflow failed due to me... | 2018-10-15 20:30:00 | 2018-10-15 20:30:02 |
+--------------------------------------+----------------+-------------------------------------------+--------------------+--------------------------------------+---------+------------------------------+---------------------+---------------------+

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/618618

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/618618
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=b7f06883f46a673a387b352d1ce45b2c74ca76e7
Submitter: Zuul
Branch: master

commit b7f06883f46a673a387b352d1ce45b2c74ca76e7
Author: Rabi Mishra <email address hidden>
Date: Sat Nov 17 15:59:57 2018 +0530

    Fix rotate_fernet_keys workflow to not use heat deployment

    We've disabled os-collect-config after config-download became
    the default from rocky. However, this workflow is currently using
    heat software deployment for deploy_ssh_key task. This changes to
    use inventory generated by config-download and removes the
    deploy_ssh_key task.

    Also fixes swift_ring.v1.reblance to use the correct inventory.

    Change-Id: Iab9d30e1b5b3008ef3130f64225b4f7fd4082214
    Closes-Bug: #1803814

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/618950

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/618950
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=8dd9125d16dd68af2c034c11601c5c4306264e3c
Submitter: Zuul
Branch: stable/rocky

commit 8dd9125d16dd68af2c034c11601c5c4306264e3c
Author: Rabi Mishra <email address hidden>
Date: Sat Nov 17 15:59:57 2018 +0530

    Fix rotate_fernet_keys workflow to not use heat deployment

    We've disabled os-collect-config after config-download became
    the default from rocky. However, this workflow is currently using
    heat software deployment for deploy_ssh_key task. This changes to
    use inventory generated by config-download and removes the
    deploy_ssh_key task.

    Also fixes swift_ring.v1.reblance to use the correct inventory.

    Change-Id: Iab9d30e1b5b3008ef3130f64225b4f7fd4082214
    Closes-Bug: #1803814
    (cherry picked from commit b7f06883f46a673a387b352d1ce45b2c74ca76e7)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 9.5.0 release.