Openstack overcloud delete should call the undeploy workflow

[Adriano Petrich]

Description of problem:
I tried to deploy from the GUI with 3 controllers and 1 compute (all other settings were left as default). Deployment failed because the controllers couldn't ping pool.ntp.org (probably a missing DNS setting in the ctlplane) and the GUI showed:

Deployment of plan plan failed
Ansible failed, check log at /var/lib/mistral/plan/ansible.log.

The GUI didn't show a "delete" button or any other option - so I deleted the stack from the CLI. However, even with the stack deleted the GUI still showed the same failure and there is no "Deploy" button to try the deployment again.

Version-Release number of selected component (if applicable):
openstack-tripleo-ui-9.3.1-0.20180921180341.df30b55.el7ost.noarch

How reproducible:
100%

Steps to Reproduce:
1. Deploy from the GUI
2. Delete the stack with "openstack stack delete <<plan-name>>"
3. Return to the GUI

Actual results:
Stack is not shown as deleted, the system doesn't allow you to redeploy.

Possible Solution:

1. Update 'openstack overcloud delete' command to use undeploy_plan workflow instead of 'stack delete'. [1]

2. In cases where documentation mentions using 'openstack stack delete' to delete the deployment, replace it with 'openstack overcloud delete' (to completely delete deployment and plan) or `openstack workflow execution create tripleo.deployment.v1.undeploy_plan '{"container":"<planName>}'` to delete the deployment only.

For the future (not part of this bug) we need to change the 'openstack overcloud delete' to just undeploy plan but not delete it. Deleting plan needs to be separate operation done by 'openstack overcloud plan delete'.

[1] https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/v1/overcloud_delete.py

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/616199

[Adriano Petrich (apetrich)]

Sorry the bug report is a copy and paste of a downstream bug. it is better described as (also copied from the downstream bug):

New bug description:
We don't have a CLI command to properly undeploy the overcloud. There is a workflow for it, and the GUI uses the right workflow, but the CLI doesn't support it yet.

We propose to update the "openstack overcloud delete" command to call the proper workflow. Currently, this command deletes the plan in addition to deleting the stack - which is not what we want... It should only call the undeploy workflow same as the UI does.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/616199
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=2ac2e9b57de791c6c5936bb63d979d9c47f186a5
Submitter: Zuul
Branch: master

commit 2ac2e9b57de791c6c5936bb63d979d9c47f186a5
Author: apetrich <email address hidden>
Date: Wed Nov 7 14:19:25 2018 +0100

    Change the overcloud delete command to use undeploy_plan

    We don't have a CLI command to properly undeploy the overcloud.
    There is a workflow for it, and the GUI uses the right workflow,
    but the CLI doesn't support it yet.

    Updating "openstack overcloud delete" command to call the proper workflow

    Added a release note because this is not a backwards compatible change

    Change-Id: If14a7876445b052cd255cdd5142ff400a815ace9
    Closes-Bug: #1802102

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/623264

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/623264
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=b64127a01ed5c16bfb8bbfa4d25c67d4577a9dc3
Submitter: Zuul
Branch: stable/rocky

commit b64127a01ed5c16bfb8bbfa4d25c67d4577a9dc3
Author: apetrich <email address hidden>
Date: Wed Nov 7 14:19:25 2018 +0100

    Change the overcloud delete command to use undeploy_plan

    We don't have a CLI command to properly undeploy the overcloud.
    There is a workflow for it, and the GUI uses the right workflow,
    but the CLI doesn't support it yet.

    Updating "openstack overcloud delete" command to call the proper workflow

    Added a release note because this is not a backwards compatible change

    Change-Id: If14a7876445b052cd255cdd5142ff400a815ace9
    Closes-Bug: #1802102
    (cherry picked from commit 2ac2e9b57de791c6c5936bb63d979d9c47f186a5)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/625675

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/625675
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=13b8fc6b304ee28d536fa95bb20db36739a3b523
Submitter: Zuul
Branch: master

commit 13b8fc6b304ee28d536fa95bb20db36739a3b523
Author: apetrich <email address hidden>
Date: Mon Dec 17 18:38:54 2018 +0100

    Fix stack.name to stack.stack_name

    The property that holds the stack name was wrongly named as stack.name
    This fix to the correct name. It also depends on the patch that makes it
    wait on delete cases.

    Change-Id: Ibf837cd2cc0488445229e50d52bb631188227e0e
    Depends-on: I45442ef2c622463a957c84be47f38ec4528001ac
    Closes-Bug: #1802102

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/626124

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/626124
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=f422425e85bec30200d83ccb10627acc647620f8
Submitter: Zuul
Branch: stable/rocky

commit f422425e85bec30200d83ccb10627acc647620f8
Author: apetrich <email address hidden>
Date: Mon Dec 17 18:38:54 2018 +0100

    Fix stack.name to stack.stack_name

    The property that holds the stack name was wrongly named as stack.name
    This fix to the correct name. It also depends on the patch that makes it
    wait on delete cases.

    Change-Id: Ibf837cd2cc0488445229e50d52bb631188227e0e
    Depends-on: I45442ef2c622463a957c84be47f38ec4528001ac
    Closes-Bug: #1802102
    (cherry picked from commit 13b8fc6b304ee28d536fa95bb20db36739a3b523)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 11.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 10.6.1 release.