deactivation of interactive login in get-occ-config.sh

Bug #1800834 reported by James Slagle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
James Slagle

Bug Description

The script "/usr/share/openstack-tripleo-heat-templates/deployed-server/scripts/get-occ-config.sh" is using -tt SSH Option:

$grep SSH_OPTIONS /usr/share/openstack-tripleo-heat-templates/deployed-server/scripts/get-occ-config.sh

SSH_OPTIONS="-tt -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o LogLevel=Verbose -o PasswordAuthentication=no -o ConnectionAttempts=32"
            ssh $SSH_OPTIONS -i $SUBNODES_SSH_KEY $host "echo '$config' > deployed-server.json"
            ssh $SSH_OPTIONS -i $SUBNODES_SSH_KEY $host sudo mkdir -p -m 0700 /var/lib/os-collect-config/local-data/ || true
            ssh $SSH_OPTIONS -i $SUBNODES_SSH_KEY $host sudo cp deployed-server.json /var/lib/os-collect-config/local-data/deployed-server.json
            ssh $SSH_OPTIONS -i $SUBNODES_SSH_KEY $host sudo systemctl start os-collect-config
            ssh $SSH_OPTIONS -i $SUBNODES_SSH_KEY $host sudo systemctl enable os-collect-config

The "-tt" option forces a TTY allocation and so the connection is handled like an interactive login.

We'd like the ability to remove -tt.

Changed in tripleo:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → James Slagle (james-slagle)
milestone: none → stein-2
tags: added: pike-backport-potential queens-backport-potential rocky-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/614493

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/614493
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=30741a22d70c01e81eed6c7503bf5c04919d856f
Submitter: Zuul
Branch: master

commit 30741a22d70c01e81eed6c7503bf5c04919d856f
Author: James Slagle <email address hidden>
Date: Wed Oct 31 09:05:18 2018 -0400

    Make $SSH_OPTIONS overrideable

    In some cases, it may be desireable to override $SSH_OPTIONS as used by
    the deployed-server get-occ-config.sh script. Particularly in
    environments that wish to remove -tt.

    This patches makes it so that the value can be overridden via the shell.

    Change-Id: I14ab6765b3e55f602bb8ae56a313fce9812e3f59
    Closes-Bug: #1800834

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/618841

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/618842

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (stable/rocky)

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: stable/rocky
Review: https://review.openstack.org/618841
Reason: clearing the gate

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (stable/queens)

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: stable/queens
Review: https://review.openstack.org/618842
Reason: clearing the gate

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 10.2.0

This issue was fixed in the openstack/tripleo-heat-templates 10.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.openstack.org/618841
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2ff663bc8743f8ce57d86dd477e606018d60794c
Submitter: Zuul
Branch: stable/rocky

commit 2ff663bc8743f8ce57d86dd477e606018d60794c
Author: James Slagle <email address hidden>
Date: Wed Oct 31 09:05:18 2018 -0400

    Make $SSH_OPTIONS overrideable

    In some cases, it may be desireable to override $SSH_OPTIONS as used by
    the deployed-server get-occ-config.sh script. Particularly in
    environments that wish to remove -tt.

    This patches makes it so that the value can be overridden via the shell.

    Change-Id: I14ab6765b3e55f602bb8ae56a313fce9812e3f59
    Closes-Bug: #1800834
    (cherry picked from commit 30741a22d70c01e81eed6c7503bf5c04919d856f)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.openstack.org/618842
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3469955cac067aad4ee43a6172ef36909960b892
Submitter: Zuul
Branch: stable/queens

commit 3469955cac067aad4ee43a6172ef36909960b892
Author: James Slagle <email address hidden>
Date: Wed Oct 31 09:05:18 2018 -0400

    Make $SSH_OPTIONS overrideable

    In some cases, it may be desireable to override $SSH_OPTIONS as used by
    the deployed-server get-occ-config.sh script. Particularly in
    environments that wish to remove -tt.

    This patches makes it so that the value can be overridden via the shell.

    Change-Id: I14ab6765b3e55f602bb8ae56a313fce9812e3f59
    Closes-Bug: #1800834
    (cherry picked from commit 30741a22d70c01e81eed6c7503bf5c04919d856f)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 8.2.0

This issue was fixed in the openstack/tripleo-heat-templates 8.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 9.2.0

This issue was fixed in the openstack/tripleo-heat-templates 9.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.