Overcloud deployment failed because of docker-puppet-crond container conflict

[Steve Baker]

Overcloud deployment has failed with this message:

2018-10-19 14:46:51 | "2018-10-19 18:34:10,726 ERROR: 19339 -- Failed running docker-puppet.py for crond",
2018-10-19 14:46:51 | "2018-10-19 18:34:10,726 ERROR: 19339 -- /usr/bin/docker-current: Error response from daemon: Conflict. The container name \"/docker-puppet-crond\" is already in use by container 622001fb6d5d2756fac0cc99b5a79720e1ac44062eedbf32bce9345cfb75d518. You have to remove (or rename) that container to be able to reuse that name..",
2018-10-19 14:46:51 | "See '/usr/bin/docker-current run --help'.",

while processing compute-0 node. Deployment command line:

openstack overcloud deploy \
    --templates /usr/share/openstack-tripleo-heat-templates \
    --libvirt-type kvm --control-flavor baremetal --compute-flavor baremetal --ceph-storage-flavor baremetal --block-storage-flavor oooq_blockstorage --swift-storage-flavor oooq_objectstorage --timeout 90 --ntp-server 10.5.26.10 -e /home/stack/cloud-names.yaml -e /home/stack/neutronl3ha.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/docker.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/docker-ha.yaml -e /home/stack/containers-default-parameters.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/network-isolation.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/net-single-nic-with-vlans.yaml -e /home/stack/network-environment.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/low-memory-usage.yaml -e /home/stack/inject-trust-anchor.yaml --validation-warnings-fatal -e /usr/share/openstack-tripleo-heat-templates/environments/config-debug.yaml

There's no trace of any container in every node (both controllers and computes). The "docker ps" and "docker ps -a" commands output are empty.

[Steve Baker (steve-stevebaker)]

docker-puppet.py should use unique container names always, and auto --rm on exit

[Bogdan Dobrelya (bogdando)]

I wonder if it makes sense to use paunch as a lib

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/613295
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6bec6c885f4e3986bec85b21e49b537876cd732c
Submitter: Zuul
Branch: master

commit 6bec6c885f4e3986bec85b21e49b537876cd732c
Author: Bogdan Dobrelya <email address hidden>
Date: Thu Oct 25 14:00:57 2018 +0200

    Ensure unique containers names in docker-puppet

    Use paunch as a library to not duplicate code around.
    We'll need to add the logger once we have paunch 4.0.1
    and rpm promoted with the recent logging fixes.

    Closes-Bug: #1799573

    Change-Id: I4386b155a4bdba430dc350914db7a6b6fdf92ac0
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.openstack.org/614450

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/614450
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5ccbdda93e38740abdd06f0a4bd32adf1ac9e90c
Submitter: Zuul
Branch: stable/rocky

commit 5ccbdda93e38740abdd06f0a4bd32adf1ac9e90c
Author: Bogdan Dobrelya <email address hidden>
Date: Thu Oct 25 14:00:57 2018 +0200

    Ensure unique containers names in docker-puppet

    Use paunch as a library to not duplicate code around.

    Related-Bug: #1799573

    Change-Id: I4386b155a4bdba430dc350914db7a6b6fdf92ac0
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 6bec6c885f4e3986bec85b21e49b537876cd732c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/628162

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/628162
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b6cfecbe322c22edd4b1a351eeb304fda564eea0
Submitter: Zuul
Branch: stable/queens

commit b6cfecbe322c22edd4b1a351eeb304fda564eea0
Author: Bogdan Dobrelya <email address hidden>
Date: Thu Oct 25 14:00:57 2018 +0200

    Ensure unique containers names in docker-puppet

    Use paunch as a library to not duplicate code around.

    Closes-Bug: #1799573

    Change-Id: I4386b155a4bdba430dc350914db7a6b6fdf92ac0
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 6bec6c885f4e3986bec85b21e49b537876cd732c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.3.0 release.