plan-environment.yaml in home dir can break undercloud install/upgrade

[Emilien Macchi]

Credits to James Slagle for the bug report: https://bugzilla.redhat.com/show_bug.cgi?id=1638931

openstack tripleo deploy, which drives the undercloud installer and upgrade, defaults to using plan-environment.yaml from the current directory as set in contsants.py.

This can cause issues when using the openstack undercloud commands if you happen to have a plan-environment.yaml from your overcloud (or from anywhere) in the current directory.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/611189

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/611189
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=45395e8c0d8b2f790965f3b450b8cfdb95848d9e
Submitter: Zuul
Branch: master

commit 45395e8c0d8b2f790965f3b450b8cfdb95848d9e
Author: Emilien Macchi <email address hidden>
Date: Tue Oct 16 18:10:42 2018 -0400

    Fix defaults to templates, roles-file and plan-environment

    This change updates the --templates parameter to now have a default
    which makes it optional and only necessary when something different than
    the default. Additionally we're removing the defaults as it causes
    issues, when someone download the overcloud plan on the undercloud
    because it would use the current working director to load the file.
    Now it will use the --templates folder as a base for the default value
    and will take the specific file if --roles-file or
    --plan-environment-file is specified.

    Change-Id: Ia0c8a7caaf8f24ef1e5b0858d57827633f2473e9
    Closes-Bug: #1797922
    Co-Authored-By: Alex Schultz <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 11.1.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/625917
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=7835a8a300d72776b0dd9fb9b3b7af7dbc9c670e
Submitter: Zuul
Branch: stable/rocky

commit 7835a8a300d72776b0dd9fb9b3b7af7dbc9c670e
Author: Emilien Macchi <email address hidden>
Date: Tue Oct 16 18:10:42 2018 -0400

    Fix defaults to templates, roles-file and plan-environment

    This change updates the --templates parameter to now have a default
    which makes it optional and only necessary when something different than
    the default. Additionally we're removing the defaults as it causes
    issues, when someone download the overcloud plan on the undercloud
    because it would use the current working director to load the file.
    Now it will use the --templates folder as a base for the default value
    and will take the specific file if --roles-file or
    --plan-environment-file is specified.

    Change-Id: Ia0c8a7caaf8f24ef1e5b0858d57827633f2473e9
    Closes-Bug: #1797922
    Co-Authored-By: Alex Schultz <email address hidden>
    (cherry picked from commit 45395e8c0d8b2f790965f3b450b8cfdb95848d9e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 10.6.1 release.