Wrong documentation for the role parameter in the update cmd.

Bug #1796860 reported by Sofer Athlan-Guyot
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Low
Sofer Athlan-Guyot

Bug Description

Hi,

It currently reads[1]

"NOTE: Using this parameter with nodes of "
"controlplane roles (e.g. \"--nodes "
"controller-1\") is NOT supported and WILL "
"end badly unless you include ALL nodes of "
"that role as a comma separated string. You "
"should instead use the --roles parameter "
"for controlplane roles and specify the "
"role name."

but this constraint doesn't apply to update, only to upgrade.

[1] https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/v1/overcloud_update.py#L89..L97

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/608921

Changed in tripleo:
assignee: nobody → Sofer Athlan-Guyot (sofer-athlan-guyot)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/608921
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=c56face82e38078c1cb89dc2df1178b6f93c00f9
Submitter: Zuul
Branch: master

commit c56face82e38078c1cb89dc2df1178b6f93c00f9
Author: Sofer Athlan-Guyot <email address hidden>
Date: Tue Oct 9 13:23:27 2018 +0200

    Fix documentation string for update roles and nodes option.

    There was some leftover from the original upgrade options. Removed
    them and clarify the behavior.

    Change-Id: I99492ec6066ce0420bc3b636989270b75aaf7d26
    Closes-Bug: #1796860

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 11.1.0

This issue was fixed in the openstack/python-tripleoclient 11.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.