Ansible "dry-run" fails with TASK [set is_bootstrap_node fact] - FAILED! => {"msg": "The task includes an option with an undefined variable.

Bug #1795488 reported by James Slagle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Incomplete
Medium
James Slagle

Bug Description

Description of problem:
When trying to perform a "dry-run" on config download playbooks, check fails on the task :TASK [set is_bootstrap_node fact]

TASK [set is_bootstrap_node fact] *********************************************************************************************************************************************************************************
fatal: [controller-2]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'stdout'\n\nThe error appears to have been in '/home/stack/cd-overcloud/ControllerOpenstack/host_prep_tasks.yaml': line 290, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n register: bootstrap_node\n - name: set is_bootstrap_node fact\n ^ here\n"}
fatal: [controller-1]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'stdout'\n\nThe error appears to have been in '/home/stack/cd-overcloud/ControllerOpenstack/host_prep_tasks.yaml': line 290, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n register: bootstrap_node\n - name: set is_bootstrap_node fact\n ^ here\n"}
fatal: [controller-0]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'stdout'\n\nThe error appears to have been in '/home/stack/cd-overcloud/ControllerOpenstack/host_prep_tasks.yaml': line 290, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n register: bootstrap_node\n - name: set is_bootstrap_node fact\n ^ here\n"}

Version-Release number of selected component (if applicable):
openstack-tripleo-common-9.3.1-0.20180920204842.el7ost.noarch

How reproducible:

Steps to Reproduce:
1. Install undercloud
2. Create stack with openstack overcloud deploy --stack-only
3. Generate config download files with openstack overcloud config download --config-dir cd-overcloud --name overcloud
4. Generate ansible inventory
5. Run ansible with --check option

Changed in tripleo:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → James Slagle (james-slagle)
milestone: none → stein-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/607019

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/611658

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by James Slagle (<email address hidden>) on branch: master
Review: https://review.openstack.org/607019
Reason: this is no longer relevant on master due to:

https://review.openstack.org/#/c/605430/

This will be a Rocky only backport instead:

https://review.openstack.org/611658

Revision history for this message
wes hayutin (weshayutin) wrote :
Revision history for this message
James Slagle (james-slagle) wrote :

wes, it's a different error. The CI log you posted shows:

'haproxy_public_tls_inject_short_bootstrap_node_name' is undefined

likely that is related to this patch:
https://review.openstack.org/#/c/605430/

Looks like there is a separate bug already:
https://launchpad.net/bugs/1798525

And marios has proposed a revert:
https://review.openstack.org/#/c/611518/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.openstack.org/611658
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7efe1087df1bd04e57afc67e1c6cb1ec96d161df
Submitter: Zuul
Branch: stable/rocky

commit 7efe1087df1bd04e57afc67e1c6cb1ec96d161df
Author: James Slagle <email address hidden>
Date: Mon Oct 1 14:24:30 2018 -0400

    [Rocky ONLY] Fix haproxy cert inject for check mode

    Fixes the "Assign bootstrap node" task so that it runs under check mode
    so that the bootstrap_node variable is created. Otherwise, the
    subsequent tasks that use that variable fail during check mode.

    This is a Rocky ONLY backport since it's no longer relevant on master
    due to the template being refactored in:
    https://review.openstack.org/#/c/605430/

    Change-Id: I213abb3fe4608f9a4b6b1ce4956feb6e2766088f
    Closes-Bug: #1795488
    (cherry picked from commit 72dcf19b88543125f9c77a6e2b45e57e6dbc20c6)

tags: added: in-stable-rocky
Changed in tripleo:
milestone: stein-1 → stein-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 9.1.0

This issue was fixed in the openstack/tripleo-heat-templates 9.1.0 release.

Changed in tripleo:
milestone: stein-2 → stein-3
Changed in tripleo:
milestone: stein-3 → train-1
Changed in tripleo:
milestone: train-1 → train-2
Changed in tripleo:
milestone: train-2 → train-3
Changed in tripleo:
milestone: train-3 → ussuri-1
Changed in tripleo:
milestone: ussuri-1 → ussuri-2
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-2 → ussuri-3
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-3 → ussuri-rc3
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-rc3 → victoria-1
Changed in tripleo:
milestone: victoria-1 → victoria-3
Changed in tripleo:
milestone: victoria-3 → wallaby-1
Changed in tripleo:
milestone: wallaby-1 → wallaby-2
Changed in tripleo:
milestone: wallaby-2 → wallaby-3
Revision history for this message
Marios Andreou (marios-b) wrote :

This is an automated action. Bug status has been set to 'Incomplete' and target milestone has been removed due to inactivity. If you disagree please re-set these values and reach out to us on freenode #tripleo

Changed in tripleo:
milestone: wallaby-3 → none
status: In Progress → Incomplete
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.