Clean up old templates for updates with pre-containerization pacemaker

[Jiří Stránský]

We obsoleted these resources with move to containers, but the templates that used to implement these are still referenced in some envs and CI envs in the t-h-t tree.

https://github.com/openstack/tripleo-heat-templates/blob/master/environments/docker-ha.yaml#L10-L11

[David Peacock (davidjpeacock)]

Please can you give us more information here; we're not sure what to do with this.

[Jiří Stránský (jistr)]

There's a bunch of files which are completely obsolete now, but still live in t-h-t, e.g.:

https://github.com/openstack/tripleo-heat-templates/blob/1badfc470a0ae95f32ec5fe157193285dece18d3/extraconfig/tasks/pre_puppet_pacemaker.yaml

https://github.com/openstack/tripleo-heat-templates/blob/1badfc470a0ae95f32ec5fe157193285dece18d3/extraconfig/tasks/post_puppet_pacemaker.yaml

... and others. They're related to updates/upgrades of pacemaker and services managed by pacemaker, and they were only used before we went containerized.

The full scope of this still needs to be further investigated. E.g. we can't simply delete the files because they are still referenced from places (that doesn't mean they're useful though).

[Jiří Stránský (jistr)]

Anything pacemaker-related in this directory is suspicious and needs to be checked:

https://github.com/openstack/tripleo-heat-templates/tree/1badfc470a0ae95f32ec5fe157193285dece18d3/extraconfig/tasks

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/608242

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/608242
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7a438651af90759beb6b42725ba83b999bbbe4b6
Submitter: Zuul
Branch: master

commit 7a438651af90759beb6b42725ba83b999bbbe4b6
Author: Jiri Stransky <email address hidden>
Date: Fri Oct 5 13:45:44 2018 +0200

    Remove obsolete code for handling Pacemakerized resource restarts

    Remove scripts and templates which dealt with Pacemaker and its
    resource restarts before we moved to containerized deployments. These
    should all now be unused.

    Many environments had this mapping:

        OS::TripleO::Tasks::ControllerPreConfig: OS::Heat::None
        OS::TripleO::Tasks::ControllerPostConfig: OS::Heat::None
        OS::TripleO::Tasks::ControllerPostPuppetRestart: ../../extraconfig/tasks/post_puppet_pacemaker_restart.yaml

    The ControllerPostPuppetRestart is only ever referenced from
    ControllerPostConfig, so if ControllerPostConfig is OS::Heat::None, it
    doesn't matter what ControllerPostPuppetRestart is mapped to.

    Change-Id: Ibca72affb3d55cf62e5dfb52fe56b3b1c8b12ee0
    Closes-Bug: #1794720

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.1.0 release.