Remove legacy controller-v6.j2.yaml NIC config templates

[Dan Sneddon]

Each of the built-in NIC config templates in the network/config/* directory of tripleo-heat-templates has a special version called controller-v6.j2.yaml which is no longer needed. The original reason for this file was to have a version of the Controller NIC configs that had an IPv6 default gateway on External and an IPv4 default gateway on the Control Plane. The role.role.j2.yaml file in each of those directories will now produce the correct routes if the roles_data.yaml is updated.

For example::

  default_route_networks: ['External', 'ControlPlane']

If the above is placed in the Controller definition in roles_data.yaml, the generated NIC config templates will contain a default route on both the External and ControlPlane networks. When the External network is IPv6 and the ControlPlane is IPv4, these two default routes do not conflict, and the end result is the same as including controller-v6.yaml.

We originally left both versions in each NIC config template directory to support upgrades, but we can document that users should use controller.yaml instead of controller-v6.yaml when upgrading from a previous version.

[Cédric Jeanneret (cjeanner)]

Is it still an issue?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/644662

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/644662
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9e265a209df9799f9ed80b82f078d26cd3141fe3
Submitter: Zuul
Branch: master

commit 9e265a209df9799f9ed80b82f078d26cd3141fe3
Author: Dan Sneddon <email address hidden>
Date: Thu Oct 25 10:42:08 2018 -0700

    Remove legacy controller-v6.yaml NIC config templates

    Recent changes to the network interface configurations in THT
    make it unneccessary to use the special controller-v6.yaml
    template. Instead, adding both an IPv6 and an IPv4 network
    to the default_route_networks: parameter in roles_data.yaml
    will result in both an IPv4 and an IPv6 default route.

    For instance:
      default_route_networks: ['ControlPlane', 'External']

    Change-Id: I23ae304362bd0029cc921010155414f023b19c54
    Closes-bug: 1793581

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.2.0 release.