[Upgrades] Could not find the requested service openstack-glance-registry

[Jose Luis Franco]

When openstack-glance-registry service is enabled in service parameters an error is obtained during upgrades:

2018-09-14 21:14:09 | 2018-09-14 21:14:09.412 55847 WARNING tripleoclient.v1.tripleo_upgrade.Upgrade [-] fatal: [centos-7-rax-dfw-0002027837]: FAILED! => {"changed": false, "msg": "Could not find the requested service openstack-glance-registry: host"}

LOGS: http://logs.openstack.org/16/602416/3/check/tripleo-ci-centos-7-standalone/2f37c31/logs/undercloud/home/zuul/standalone_upgrade.log.txt.gz#_2018-09-14_21_14_09

This happens because we're stopping the service directly without checking previously if it was enabled or not.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/603581
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6ea85bc5bb620a078958f19ec5308ada1f0d0562
Submitter: Zuul
Branch: master

commit 6ea85bc5bb620a078958f19ec5308ada1f0d0562
Author: Jose Luis Franco Arza <email address hidden>
Date: Wed Sep 19 09:53:26 2018 +0200

    Check if openstack-glance-registry is enabled before stopping it.

    If glance-registry is defined in the service
    parameters, then during upgrade, it will try
    to stop it. However, as the service is not
    enabled the service stop task will fail.
    This patch checks if the service is enabled
    before stopping it. And covers the case in
    which the service might be disabled but still
    running.

    Closes-Bug: #1793557
    Change-Id: I21d17c05f555b25f709f314f6a19a011a3d10a8d

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.0.0 release.