tripleo

do not ship extraneous rabbitmq plugins in tripleo containers

Bug #1791077 reported by Michele Baldessari on 2018-09-06

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	High	wes hayutin	tripleo stein-1

Bug Description

We are doing this in the rabbit kolla container in tripleo:
{% block rabbitmq_install_plugins %}

RUN rm -rf /var/lib/rabbitmq/* \
    && ln -s /usr/lib/rabbitmq/lib/rabbitmq_server-3.6.* /usr/lib/rabbitmq/lib/rabbitmq_server-3.6 \
    && curl -o /usr/lib/rabbitmq/lib/rabbitmq_server-3.6/plugins/rabbitmq_clusterer-3.6.x-667f92b0.ez http://www.rabbitmq.com/community-plugins/v3.6.x/rabbitmq_clusterer-3.6.x-667f92b0.ez \
    && /usr/lib/rabbitmq/bin/rabbitmq-plugins enable --offline \
       rabbitmq_management \
       rabbitmq_clusterer

{% endblock %}

We should disable this as:
a) this is unwanted
b) we want to use only plugins shipped with rpm
c) we do not use those two plugins anyway

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-06: Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/600426

Changed in tripleo:
status:	Triaged → In Progress

Alex Schultz (alex-schultz) on 2018-09-07

Changed in tripleo:
milestone:	rocky-rc2 → stein-1

OpenStack Infra (hudson-openstack) on 2018-09-07

Changed in tripleo:
assignee:	Michele Baldessari (michele) → wes hayutin (weshayutin)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-09: Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/600426
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=699d5002ccf43f8f20594116b9e5e0ea3b2d6d18
Submitter: Zuul
Branch: master

commit 699d5002ccf43f8f20594116b9e5e0ea3b2d6d18
Author: Michele Baldessari <email address hidden>
Date: Thu Sep 6 14:16:52 2018 +0200

Disable external plugins in rabbitmq container

We are doing this in the rabbit kolla container in tripleo:
{% block rabbitmq_install_plugins %}

    RUN rm -rf /var/lib/rabbitmq/* \
        && ln -s /usr/lib/rabbitmq/lib/rabbitmq_server-3.6.* /usr/lib/rabbitmq/lib/rabbitmq_server-3.6 \
        && curl -o /usr/lib/rabbitmq/lib/rabbitmq_server-3.6/plugins/rabbitmq_clusterer-3.6.x-667f92b0.ez http://www.rabbitmq.com/community-plugins/v3.6.x/rabbitmq_clusterer-3.6.x-667f92b0.ez \
        && /usr/lib/rabbitmq/bin/rabbitmq-plugins enable --offline \
           rabbitmq_management \
           rabbitmq_clusterer

{% endblock %}

    We should disable this as:
    a) this is unwanted
    b) we want to use only plugins shipped with rpm
    c) we do not use those two plugins anyway

We do this by simply overriding the "rabbitmq_install_plugins" to a
comment.

Change-Id: I14f0f778d21b0d2a27d6e02468dac2cc1c8f25f7
Closes-Bug: #1791077

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-09: Fix proposed to tripleo-common (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/601074

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-09: Fix proposed to tripleo-common (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/601075

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-09: Fix proposed to tripleo-common (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/601077

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-17: Fix merged to tripleo-common (stable/rocky)

Reviewed: https://review.openstack.org/601074
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5ca991aba3b80d4d037c7d292ddc9d7762a67f0a
Submitter: Zuul
Branch: stable/rocky

commit 5ca991aba3b80d4d037c7d292ddc9d7762a67f0a
Author: Michele Baldessari <email address hidden>
Date: Thu Sep 6 14:16:52 2018 +0200

Disable external plugins in rabbitmq container

We are doing this in the rabbit kolla container in tripleo:
{% block rabbitmq_install_plugins %}

    RUN rm -rf /var/lib/rabbitmq/* \
        && ln -s /usr/lib/rabbitmq/lib/rabbitmq_server-3.6.* /usr/lib/rabbitmq/lib/rabbitmq_server-3.6 \
        && curl -o /usr/lib/rabbitmq/lib/rabbitmq_server-3.6/plugins/rabbitmq_clusterer-3.6.x-667f92b0.ez http://www.rabbitmq.com/community-plugins/v3.6.x/rabbitmq_clusterer-3.6.x-667f92b0.ez \
        && /usr/lib/rabbitmq/bin/rabbitmq-plugins enable --offline \
           rabbitmq_management \
           rabbitmq_clusterer

{% endblock %}

    We should disable this as:
    a) this is unwanted
    b) we want to use only plugins shipped with rpm
    c) we do not use those two plugins anyway

We do this by simply overriding the "rabbitmq_install_plugins" to a
comment.

    Change-Id: I14f0f778d21b0d2a27d6e02468dac2cc1c8f25f7
    Closes-Bug: #1791077
    (cherry picked from commit 699d5002ccf43f8f20594116b9e5e0ea3b2d6d18)

tags:

added: in-stable-rocky

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-25: Fix included in openstack/tripleo-common 9.4.0

This issue was fixed in the openstack/tripleo-common 9.4.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-25: Change abandoned on tripleo-common (stable/queens)

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: stable/queens
Review: https://review.openstack.org/601075
Reason: Purging the gate to free up resources and address the timeout issues

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-27: Fix merged to tripleo-common (stable/queens)

Reviewed: https://review.openstack.org/601075
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=573b22b81f449d414dcfcef50245c67d1853c877
Submitter: Zuul
Branch: stable/queens

commit 573b22b81f449d414dcfcef50245c67d1853c877
Author: Michele Baldessari <email address hidden>
Date: Thu Sep 6 14:16:52 2018 +0200

Disable external plugins in rabbitmq container

We are doing this in the rabbit kolla container in tripleo:
{% block rabbitmq_install_plugins %}

    RUN rm -rf /var/lib/rabbitmq/* \
        && ln -s /usr/lib/rabbitmq/lib/rabbitmq_server-3.6.* /usr/lib/rabbitmq/lib/rabbitmq_server-3.6 \
        && curl -o /usr/lib/rabbitmq/lib/rabbitmq_server-3.6/plugins/rabbitmq_clusterer-3.6.x-667f92b0.ez http://www.rabbitmq.com/community-plugins/v3.6.x/rabbitmq_clusterer-3.6.x-667f92b0.ez \
        && /usr/lib/rabbitmq/bin/rabbitmq-plugins enable --offline \
           rabbitmq_management \
           rabbitmq_clusterer

{% endblock %}

    We should disable this as:
    a) this is unwanted
    b) we want to use only plugins shipped with rpm
    c) we do not use those two plugins anyway

We do this by simply overriding the "rabbitmq_install_plugins" to a
comment.

    Change-Id: I14f0f778d21b0d2a27d6e02468dac2cc1c8f25f7
    Closes-Bug: #1791077
    (cherry picked from commit 699d5002ccf43f8f20594116b9e5e0ea3b2d6d18)

tags:

added: in-stable-queens

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-05: Fix merged to tripleo-common (stable/pike)

#10

Reviewed: https://review.openstack.org/601077
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=aad412a06869df35398c031206a323bb5ccd999d
Submitter: Zuul
Branch: stable/pike

commit aad412a06869df35398c031206a323bb5ccd999d
Author: Michele Baldessari <email address hidden>
Date: Thu Sep 6 14:16:52 2018 +0200

Disable external plugins in rabbitmq container

We are doing this in the rabbit kolla container in tripleo:
{% block rabbitmq_install_plugins %}

    RUN rm -rf /var/lib/rabbitmq/* \
        && ln -s /usr/lib/rabbitmq/lib/rabbitmq_server-3.6.* /usr/lib/rabbitmq/lib/rabbitmq_server-3.6 \
        && curl -o /usr/lib/rabbitmq/lib/rabbitmq_server-3.6/plugins/rabbitmq_clusterer-3.6.x-667f92b0.ez http://www.rabbitmq.com/community-plugins/v3.6.x/rabbitmq_clusterer-3.6.x-667f92b0.ez \
        && /usr/lib/rabbitmq/bin/rabbitmq-plugins enable --offline \
           rabbitmq_management \
           rabbitmq_clusterer

{% endblock %}

    We should disable this as:
    a) this is unwanted
    b) we want to use only plugins shipped with rpm
    c) we do not use those two plugins anyway

We do this by simply overriding the "rabbitmq_install_plugins" to a
comment.

NB: Cherry-pick not 100% clean

    Change-Id: I14f0f778d21b0d2a27d6e02468dac2cc1c8f25f7
    Closes-Bug: #1791077
    (cherry picked from commit 699d5002ccf43f8f20594116b9e5e0ea3b2d6d18)