Undercloud will create all subnets also when enable_routed_networks = False

[Harald Jensås]

In the undercloud we use a switch to enable support for routed networks.
When this is false and multiple subnets are defined in undercloud.conf all subnets are still created, but without segment association.

 * DHCP relay will not work if the subnets are on the same segment.
 * It will also not be possible to change the subnets to have segment association without first manually deleting all but the subnet and segment that is the local_subnet.

This bug is only in containerized undercloud. (Instack undercloud implements a pre-deploy vailidation.)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/600414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/600414
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=3f584233a5cef38ef9ed91480c3695b5bd97e2ea
Submitter: Zuul
Branch: master

commit 3f584233a5cef38ef9ed91480c3695b5bd97e2ea
Author: Harald Jensås <email address hidden>
Date: Thu Sep 6 12:15:00 2018 +0200

    Validate routed networks enabled if multiple subnets in conf

    Add's a validation to undercloud preflight checks to ensure
    eneble_routed_networks is True when multiple subnets is defined
    in undercloud.conf.

    Change-Id: I48ea4d70bf79c622f037469fa6d82eea7524b835
    Closes-Bug: #1791034

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/612004

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/612004
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=f4b6f4a46ae1447472ddd1af8ae8fa3e8db2ab1e
Submitter: Zuul
Branch: stable/rocky

commit f4b6f4a46ae1447472ddd1af8ae8fa3e8db2ab1e
Author: Harald Jensås <email address hidden>
Date: Thu Sep 6 12:15:00 2018 +0200

    Validate routed networks enabled if multiple subnets in conf

    Add's a validation to undercloud preflight checks to ensure
    eneble_routed_networks is True when multiple subnets is defined
    in undercloud.conf.

    Change-Id: I48ea4d70bf79c622f037469fa6d82eea7524b835
    Closes-Bug: #1791034
    (cherry picked from commit 3f584233a5cef38ef9ed91480c3695b5bd97e2ea)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 11.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 10.6.1 release.