Overcloud deployment fails with "No Valid Host" as oooq_ flavors don't have correct properties set

[yatin]

Reproduction steps:-
git clone https://github.com/openstack/tripleo-quickstart
cd tripleo-quickstart
bash quickstart.sh -R master-tripleo-ci --no-clone --tags all -e undercloud_memory=7192 -e control_memory=8692 -e compute_memory=6500 $VIRTHOST

Expected Results:-
The deployment should succeed

Actual Result:-
Overcloud Deployment fails with "No Valid Host Found"

Reason for Failure:-
Correct properties are not set for oooq_ Flavors[1], for default flavors it's set correctly[2].
So following properties also need to add to the custom flavors:-
--property resources:CUSTOM_BAREMETAL=1 --property resources:DISK_GB=0 --property resources:MEMORY_MB=0 --property resources:VCPU=0 --property capabilities:boot_option=local

I tried master deployment, not sure how adding extra properties will affect older releases, so can someone from Nova look at it?

[1] https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/overcloud-prep-flavors/templates/overcloud-prep-flavors.sh.j2#L39-L42
[2] https://github.com/openstack/tripleo-heat-templates/blob/f7c2f167d67121b3baa6eba03f2a2c23123fa4ee/extraconfig/post_deploy/undercloud_post.sh#L75

[Ronelle Landy (rlandy)]

https://review.openstack.org/#/c/579406/ may help

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/579406
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=1f9c7a1d9b1109a0f67a737789e083026414fd23
Submitter: Zuul
Branch: master

commit 1f9c7a1d9b1109a0f67a737789e083026414fd23
Author: Ronelle Landy <email address hidden>
Date: Sun Jul 1 18:33:04 2018 -0400

    Testing adding properties to flavors

    The additional properties are required for the nodes
    to deploy successfully on OVB.

    Closes-Bug: #1790770
    Change-Id: I4f08ccd8849049d587782500c526097cf24d150d

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.