VIRTHOST=ip_address and creating host via 'add_host': hostname=ip_address

Bug #1790685 reported by Sorin Sbarnea on 2018-09-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Sorin Sbarnea

Bug Description

In case provisioning does not create any machines, trileo fails to identify the error and loads the string ip_address as the ansible_hostame because this happens to be the column title fron the file.

VIRTHOST=ip_address

15:50:54 TASK [Add virthost] ************************************************************
15:50:54 task path: /home/jenkins/workspace/tripleo-quickstart-gate-master-delorean-quick-basic/playbooks/quickstart.yml:8
15:50:54 Tuesday 04 September 2018 14:50:54 +0000 (0:00:00.281) 0:00:00.281 *****
15:50:55 creating host via 'add_host': hostname=ip_address
15:50:55 changed: [localhost] => {"add_host": {"groups": ["virthost"], "host_name": "ip_address", "host_vars": {"ansible_fqdn": "ip_address", "ansible_host": "ip_address", "ansible_user": "root"}}, "changed": true}

Found on https://ci.centos.org/job/tripleo-quickstart-gate-master-delorean-quick-basic/6873/consoleFull

This patch is supposed to avoid this bug https://review.openstack.org/#/c/595795/

Changed in tripleo:
assignee: nobody → Sorin Sbarnea (ssbarnea)
status: Triaged → In Progress
Sorin Sbarnea (ssbarnea) on 2018-09-04
summary: - creating host via 'add_host': hostname=ip_address
+ VIRTHOST=ip_address and creating host via 'add_host':
+ hostname=ip_address
description: updated
Changed in tripleo:
milestone: rocky-rc2 → stein-1
Changed in tripleo:
milestone: stein-1 → stein-2
Changed in tripleo:
milestone: stein-2 → stein-3

Reviewed: https://review.openstack.org/595795
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=a35d6ceb1f66c4eb2ea7428a71d628dbe5259cbe
Submitter: Zuul
Branch: master

commit a35d6ceb1f66c4eb2ea7428a71d628dbe5259cbe
Author: Sorin Sbarnea <email address hidden>
Date: Thu Aug 23 15:09:45 2018 +0100

    Avoid silent parsing failure of provisioned.csv

    Removes header from cico output to avoid `tail -1` to get column
    header (ip_address) as hostname when the list would be empty
    (one line file).

    It returns failure exit code when no nodes are provisioned.

    It avoids case where column header "ip_address" ended up being
    loaded in VIRTHOST variable.

    Closes-Bug: #1790685
    Change-Id: I4a78ef1071c35491c352203aac35eb22ef1dc637

Changed in tripleo:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers