Py27 tests is failing on master - tripleo_common.tests.image.test_image_uploader.TestDockerImageUploader

[Harald Jensås]

http://logs.openstack.org/78/572678/9/check/openstack-tox-py27/6968b88/testr_results.html.gz
http://logs.openstack.org/70/595570/1/check/openstack-tox-py27/99a6297/testr_results.html.gz
http://logs.openstack.org/87/590087/3/check/openstack-tox-py27/f7bd84a/testr_results.html.gz

tripleo_common.tests.image.test_image_uploader.TestDockerImageUploader is failing on multiple different changes.

I also fails on master when I run the tests locally.

afaict this is related to this mock patch:
@mock.patch('tenacity.wait.wait_random_exponential.__call__')

It is probably related to a change in tenacity.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/596471

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/596816

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/596816
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=e2093fb7fc0a0d35d5b3ac6a8b5d4a8c373d79c7
Submitter: Zuul
Branch: master

commit e2093fb7fc0a0d35d5b3ac6a8b5d4a8c373d79c7
Author: Emilien Macchi <email address hidden>
Date: Mon Aug 27 11:34:34 2018 -0400

    Adjust tenacity mock

    Recent changes in tenacity have broken how we mock the wait call for the test.
    This change mocks out the inspect.getargspec call that is used in tenacity to
    fix our unit tests for now. I think it might be beneficial to not actually test
    the retry functionality in the paunch unit tests as it seems to be more
    of a test for tenacity than paunch.

    Change-Id: I37b09694de3ec9f31a7b945d19a83527c915b759
    Related-Bug: #1788802

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/596471
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=213968bb3fa1367b9589b75d7227de0629d77c77
Submitter: Zuul
Branch: master

commit 213968bb3fa1367b9589b75d7227de0629d77c77
Author: Alex Schultz <email address hidden>
Date: Fri Aug 24 14:32:45 2018 -0600

    Adjust tenacity mock

    Recent changes in tenacity have broken how we mock the wait call for the
    test. This change mocks out the inspect.getargspec call that is used in
    tenacity to fix our unit tests for now. I think it might be beneficial
    to not actually test the retry functionality in the tripleo-common unit
    tests as it seems to be more of a test for tenacity than tripleo-common.

    Change-Id: Ia7e9aef0ee8413fa5b09af93f7f89cb34f3f761d
    Closes-Bug: #1788802

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/597349

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/597349
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=eba4912fc4cd37442ce4603544bb070612a1df74
Submitter: Zuul
Branch: master

commit eba4912fc4cd37442ce4603544bb070612a1df74
Author: Steve Baker <email address hidden>
Date: Tue Aug 28 12:00:34 2018 +1200

    Simplify tenacity sleep mocking

    This changes the tenacity sleep mocking to not rely on tenacity
    internals, and to mock for all tests so that slow tests are not
    accidently missed.

    Change-Id: I0519e5e1c0edc1f2192a011f9fa524b5380d3518
    Related-Bug: #1788802

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.openstack.org/606865

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/606867

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/606867
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=a3f518a3e33f6a80fcd0e00907cde27d88e36c9b
Submitter: Zuul
Branch: stable/queens

commit a3f518a3e33f6a80fcd0e00907cde27d88e36c9b
Author: Emilien Macchi <email address hidden>
Date: Mon Aug 27 11:34:34 2018 -0400

    Adjust tenacity mock

    Recent changes in tenacity have broken how we mock the wait call for
    the test. This change mocks out the inspect.getargspec call that is
    used in tenacity to fix our unit tests for now. I think it might be
    beneficial to not actually test the retry functionality in the paunch
    unit tests as it seems to be more of a test for tenacity than paunch.

    Change-Id: I37b09694de3ec9f31a7b945d19a83527c915b759
    Related-Bug: #1788802
    (cherry picked from commit e2093fb7fc0a0d35d5b3ac6a8b5d4a8c373d79c7)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/606865
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=dbac03bf5f492d4f0a1f2b2db80f06589180b499
Submitter: Zuul
Branch: stable/rocky

commit dbac03bf5f492d4f0a1f2b2db80f06589180b499
Author: Emilien Macchi <email address hidden>
Date: Mon Aug 27 11:34:34 2018 -0400

    Adjust tenacity mock

    Recent changes in tenacity have broken how we mock the wait call for
    the test. This change mocks out the inspect.getargspec call that is
    used in tenacity to fix our unit tests for now. I think it might be
    beneficial to not actually test the retry functionality in the paunch
    unit tests as it seems to be more of a test for tenacity than paunch.

    Change-Id: I37b09694de3ec9f31a7b945d19a83527c915b759
    Related-Bug: #1788802
    (cherry picked from commit e2093fb7fc0a0d35d5b3ac6a8b5d4a8c373d79c7)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.0.0 release.