Octavia health manager lacking setting of config params

[Carlos Goncalves]

Octavia fails to failover an amphora with its load balancer in active-standby topology.

This issue is caused by a misconfiguration (or lack thereof) of Octavia by tripleo-common that is only setting [controller_worker]/amp_boot_network_list in the worker where is should also have been set to the health manager. An amphora instance (Nova instance) was created but did not get a Neutron port created and attached to the lb-mgmt-net.

2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker Traceback (most recent call last):
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker File "/usr/lib/python2.7/site-packages/taskflow/engines/action_engine/executor.py", line 53, in _execute_task
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker result = task.execute(**arguments)
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker File "/usr/lib/python2.7/site-packages/octavia/controller/worker/tasks/amphora_driver_tasks.py", line 367, in execute
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker amp_info = self.amphora_driver.get_info(amphora)
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker File "/usr/lib/python2.7/site-packages/octavia/amphorae/drivers/haproxy/rest_api_driver.py", line 144, in get_info
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker return self.client.get_info(amphora)
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker File "/usr/lib/python2.7/site-packages/octavia/amphorae/drivers/haproxy/rest_api_driver.py", line 412, in get_info
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker r = self.get(amp, "info")
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker File "/usr/lib/python2.7/site-packages/octavia/amphorae/drivers/haproxy/rest_api_driver.py", line 310, in request
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker _url = self._base_url(amp.lb_network_ip) + path
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker File "/usr/lib/python2.7/site-packages/octavia/amphorae/drivers/haproxy/rest_api_driver.py", line 284, in _base_url
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker if utils.is_ipv6_lla(ip):
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker File "/usr/lib/python2.7/site-packages/octavia/common/utils.py", line 68, in is_ipv6_lla
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker ip = netaddr.IPAddress(ip_address)
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker File "/usr/lib/python2.7/site-packages/netaddr/ip/__init__.py", line 306, in __init__
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker 'address from %r' % addr)
2018-08-22 14:26:21.194 24 ERROR octavia.controller.worker.controller_worker AddrFormatError: failed to detect a valid IP address from None

First reported: https://bugzilla.redhat.com/show_bug.cgi?id=1577976
Octavia storyboard: https://storyboard.openstack.org/#!/story/2003052

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/596373

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/596373
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=b00b866564abfd824fdebc8a33348a0df00a5944
Submitter: Zuul
Branch: master

commit b00b866564abfd824fdebc8a33348a0df00a5944
Author: Carlos Goncalves <email address hidden>
Date: Thu Aug 23 16:56:44 2018 +0200

    Move Octavia config opts to common config directory

    Octavia fails to failover an amphora with its load balancer in
    active-standby topology.

    This issue is caused by a misconfiguration of Octavia by tripleo-common
    where setting amp_boot_network_list and amp_secgroup_list are being
    loaded only by the worker service. These two options are shared by the
    worker and health manager services.

    Closes-Bug: #1788571
    Change-Id: Ibc73ece9bbd5dc0664fdc950ea48929a4b36b4a9

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/624304

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/624305

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: stable/rocky
Review: https://review.openstack.org/624304
Reason: bug 1808591

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/624305
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=80ec46f49e70a0ce6cd970e5853e56f741e0d7a5
Submitter: Zuul
Branch: stable/queens

commit 80ec46f49e70a0ce6cd970e5853e56f741e0d7a5
Author: Carlos Goncalves <email address hidden>
Date: Thu Aug 23 16:56:44 2018 +0200

    Move Octavia config opts to common config directory

    Octavia fails to failover an amphora with its load balancer in
    active-standby topology.

    This issue is caused by a misconfiguration of Octavia by tripleo-common
    where setting amp_boot_network_list and amp_secgroup_list are being
    loaded only by the worker service. These two options are shared by the
    worker and health manager services.

    This backport patch also includes a fix that went in commit
    b6e82e20b0345d4b3d01a2dd25c87ac33922a222 that addressed a syntax error.

    Closes-Bug: #1788571
    Change-Id: Ibc73ece9bbd5dc0664fdc950ea48929a4b36b4a9
    (cherry picked from commit b00b866564abfd824fdebc8a33348a0df00a5944)
    (cherry picked from commit f863f02b1014c0cf568578bae3ade2e0da817238)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/624304
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=f863f02b1014c0cf568578bae3ade2e0da817238
Submitter: Zuul
Branch: stable/rocky

commit f863f02b1014c0cf568578bae3ade2e0da817238
Author: Carlos Goncalves <email address hidden>
Date: Thu Aug 23 16:56:44 2018 +0200

    Move Octavia config opts to common config directory

    Octavia fails to failover an amphora with its load balancer in
    active-standby topology.

    This issue is caused by a misconfiguration of Octavia by tripleo-common
    where setting amp_boot_network_list and amp_secgroup_list are being
    loaded only by the worker service. These two options are shared by the
    worker and health manager services.

    This backport patch also includes a fix that went in commit
    b6e82e20b0345d4b3d01a2dd25c87ac33922a222 that addressed a syntax error.

    Closes-Bug: #1788571
    Change-Id: Ibc73ece9bbd5dc0664fdc950ea48929a4b36b4a9
    (cherry picked from commit b00b866564abfd824fdebc8a33348a0df00a5944)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.6.7 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 9.5.0 release.