queens: syntax error in haproxy.pp

Bug #1787227 reported by Oliver Walsh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
Oliver Walsh

Bug Description

https://review.openstack.org/591273 introduced a regression that was not caught in CI:

Error: Evaluation Error: Error while evaluating a Function Call, union(): Every parameter must be an array at /etc/puppet/modules/tripleo/manifests/haproxy.pp:1082:28 on node controller-0.localdomain

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/592072

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (stable/queens)

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/592073

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.openstack.org/592073
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c6fa26d152504b639616c0b8334e16a49bcbe508
Submitter: Zuul
Branch: stable/queens

commit c6fa26d152504b639616c0b8334e16a49bcbe508
Author: Oliver Walsh <email address hidden>
Date: Wed Aug 15 15:53:32 2018 +0100

    Revert "SSL support for haproxy -> novnc proxy connection"

    This reverts commit 9881eabad9fdf6b65f92b312e8c456163582ddfd.

    There is a syntax error in puppet-tripleo that wasn't picked up in CI.
    Also should really have been merged to master first.

    Change-Id: Id531096826aebf3b7b6eb44a17b7ce209bc5befe
    Related-bug: 1787227

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/queens)

Reviewed: https://review.openstack.org/592072
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=27bbfa8c6772b406047b2e662fe955200d4c0e25
Submitter: Zuul
Branch: stable/queens

commit 27bbfa8c6772b406047b2e662fe955200d4c0e25
Author: Oliver Walsh <email address hidden>
Date: Wed Aug 15 15:47:16 2018 +0100

    Revert "SSL support for haproxy -> novnc proxy connection"

    This reverts commit 5b49cc1d4827e6261d21929d6f901d2e35e13280.

    There is a syntax error that wasn't picked up in CI.
    Also should really have been merged to master first.

    Change-Id: I100d993af24ed6eada26e8619cde79b3930295fe
    Depends-On: Id531096826aebf3b7b6eb44a17b7ce209bc5befe
    Closes-bug: 1787227

Oliver Walsh (owalsh)
Changed in tripleo:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 8.3.6

This issue was fixed in the openstack/puppet-tripleo 8.3.6 release.

Sorin Sbarnea (ssbarnea)
Changed in tripleo:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.