containers-prep fails w/ update_containers is undefined due to lack of default

[wes hayutin]

5:19:03 TASK [extras-common : Set update_containers_append_tag for the play] ***********
15:19:03 task path: /home/jenkins/workspace/tripleo-quickstart-gate-master-delorean-quick-basic/usr/local/share/ansible/roles/extras-common/tasks/main.yml:24
15:19:03 Wednesday 08 August 2018 15:19:03 +0000 (0:00:00.121) 0:00:01.199 ******
15:19:03 fatal: [localhost]: FAILED! => {"msg": "The conditional check 'update_containers and update_containers_append_tag is undefined' failed. The error was: error while evaluating conditional (update_containers and update_containers_append_tag is undefined): 'update_containers' is undefined\n\nThe error appears to have been in '/home/jenkins/workspace/tripleo-quickstart-gate-master-delorean-quick-basic/usr/local/share/ansible/roles/extras-common/tasks/main.yml': line 24, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Set update_containers_append_tag for the play\n ^ here\n"}

https://ci.centos.org/job/tripleo-quickstart-gate-master-delorean-quick-basic/6606/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/590017

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/590017
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=f6dd92d23bb47930bea076b471cb7fcdbdc6f8a8
Submitter: Zuul
Branch: master

commit f6dd92d23bb47930bea076b471cb7fcdbdc6f8a8
Author: Wes Hayutin <email address hidden>
Date: Wed Aug 8 15:55:40 2018 -0400

    add default value for update_containers

    missing default value

    Closes-Bug: #1786106
    Change-Id: I517cc3e68edb52cedf8c9504526effd20f4f396a

[Sorin Sbarnea (ssbarnea)]

As of today, I still see failures caused by this bug https://ci.centos.org/job/tripleo-quickstart-gate-ocata-delorean-quick-basic/4956/console

[Marios Andreou (marios-b)]

noticed that your comment is pointing to quickstart-gate-ocata-delorean but wes description is pointing to quickstart-gate-master-delorean. I think the problem is we need to also include his fix in the include_packages for ocata https://github.com/openstack/tripleo-quickstart/blob/d9fc6a82f84f551ab112adc7429db5ed5cecb64e/config/release/tripleo-ci/ocata.yml#L61 (https://review.openstack.org/#/c/594314/ does master and rocky)

but this is just speculation still

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/594933

[Marios Andreou (marios-b)]

this fixed things for master/rocky

"we need to allow tripleo-roles to be updated in ci" https://review.openstack.org/#/c/594314/ tripleo-quickstart Id8eac05dbd05b49cbcc3c54b4989622802d50726

(merged already but missed the bug so adding manually)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/594933
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=3f5e97d55fa66339efe3d5787530f26ab46b99d2
Submitter: Zuul
Branch: master

commit 3f5e97d55fa66339efe3d5787530f26ab46b99d2
Author: Sorin Sbarnea <email address hidden>
Date: Wed Aug 22 12:23:41 2018 +0100

    allow tripleo-roles to be updated in ci

    We need to ensure that updates to some critical
    tripleo ansible roles are updated along with
    the other tripleo check/gated repos.

    Change-Id: Iff1d36acb878bb29440a75ee18db75201afe88ff
    Partial-Bug: #1786106
    Follow-Up: Id8eac05dbd05b49cbcc3c54b4989622802d50726

[Sorin Sbarnea (ssbarnea)]

That error can still be seen even after that change was merged.

https://ci.centos.org/job/tripleo-quickstart-gate-master-delorean-quick-basic/6783/console from https://review.openstack.org/#/c/597141/1

[Sorin Sbarnea (ssbarnea)]

Still happening today: https://ci.centos.org/view/rdo/view/tripleo-gate/job/tripleo-quickstart-gate-master-delorean-quick-basic/6899/console

[wes hayutin (weshayutin)]

I think this can be closed, the reason we saw this in ci.centos was because it was using an older hash, however we recently promoted and have the latest content.

[Sorin Sbarnea (ssbarnea)]

Wes/Quique, are you sure it can be closed because I just got an error that looks very similar to this one.

See https://ci.centos.org/job/tripleo-quickstart-gate-master-delorean-quick-basic/7276/console

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.