Multinode jobs in check pipeline in rdo sf are launched in the wrong nodepool provider

[Gabriele Cerami]

We realized that check jobs we are running in rdo sf are launched in "rdo-cloud" nodepool provider and not "rdo-cloud-tripleo"

for example this job

https://logs.rdoproject.org/19/570719/22/openstack-check/legacy-tripleo-ci-centos-7-multinode-1ctlr-featureset037-updates-master/d321bb4/

runs in "rdo-cloud" as shown from the zuul inventory variables

https://logs.rdoproject.org/19/570719/22/openstack-check/legacy-tripleo-ci-centos-7-multinode-1ctlr-featureset037-updates-master/d321bb4/zuul-info/inventory.yaml

In our workflow we are baseing some variables inclusion on the nodepool name (for example we are including multinode-rdocloud.yaml). If the jobs are running in "rdo-cloud" a set of variables is not included (for example the whole influxdb_* namespace) and part of the job fails silently.

We need to understand if we have to add another conditional for the inclusion of this variable or if all the jobs should run in "rdo-cloud-tripleo"

[Javier Peña (jpena-c)]

We have the upstream-centos-7 label defined in both the rdo-cloud and rdo-cloud-tripleo tenants [1]. I think this should not be the case, and proposed [2] with a fix.

[1] - https://softwarefactory-project.io/r/gitweb?p=config.git;a=blob;f=nodepool/rdo-cloud.yaml;h=2d94ac6b3f2b37b747a6216a29df284f0cae0f80;hb=e3fd510f2846b4320598cd62e7d1e36563b6bae9#l201
[2] - https://softwarefactory-project.io/r/13329

[Paul Belanger (pabelanger)]

This should be fixed, not limited to a single provider. As we plan for public openstack clouds (eg: vexxhost / ovh) we need to make sure these jobs are generic enough to be run on any cloud provider.

I propose we refactor the tripleo-ci jobs to allow them to be run anywhere.

[Javier Peña (jpena-c)]

Based on pabelanger's comment in https://softwarefactory-project.io/r/13329, we should make it the other way around, and make sure we can run the job in different clouds (rdo-cloud and rdo-cloud-tripleo for now, others in the future).

[Gabriele Cerami (gcerami)]

Thanks Paul and Javier.

This is impacting the jobs a lot less than I thought. The variable we are not including are already included from some other files, so we are really missing just a couple of non critical variables.
This anyway really means we need to cleanup a lot of these files.
Decreasing importance to High.