Ceph cannot be updated/upgraded in Rocky

Bug #1783949 reported by Jiří Stránský
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
Jiří Stránský

Bug Description

With the switch to config-download, we've lost the previous Ceph update/upgrade method. We need a new one which works with config-download.

Changed in tripleo:
status: Triaged → In Progress
tags: added: regression
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/585367
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=fb1a97cf66a2941b51fb47130a26f21739c56eb0
Submitter: Zuul
Branch: master

commit fb1a97cf66a2941b51fb47130a26f21739c56eb0
Author: Jiri Stransky <email address hidden>
Date: Tue Jul 24 15:22:16 2018 +0200

    Add default for ceph_ansible_playbook in update/upgrade prepare workflow

    The end goal here is to remove it completely, but there's a
    chicken-and-egg issue between removing it from tripleoclient and
    tripleo-common. First we default it here, then we remove it from
    tripleoclient, then we remove it here.

    Partial-Bug: #1783949
    Change-Id: If80f9cc2f4cb32610dc5eb87159872e28363a21a

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/587802

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/579170
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6364f2286c770b9392d432408b8aef32c8a401ae
Submitter: Zuul
Branch: master

commit 6364f2286c770b9392d432408b8aef32c8a401ae
Author: Jiri Stransky <email address hidden>
Date: Fri Jun 29 16:14:36 2018 +0200

    Update and upgrade tasks for services deployed via external deploy tasks

    Composable service templates can now define external_update_tasks and
    external_upgrade_tasks. They are meant for update/upgrade logic of
    services deployed via external_deploy_tasks. The external update
    playbook first executes external_update_tasks and then
    external_deploy_tasks, the procedure for upgrades works
    analogously. All happens within a single playbook, so variables or
    fact overrides exported from the update/upgrade tasks will be
    available to the deploy tasks during the update/upgrade procedure.

    Partial-Bug: #1783949
    Change-Id: Ib2474e8f69711cd6610a78884d5032ffd19ad249

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/582284
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=457ffd753fb92cf3945f419fad1cf7007ed97f8e
Submitter: Zuul
Branch: master

commit 457ffd753fb92cf3945f419fad1cf7007ed97f8e
Author: Jiri Stransky <email address hidden>
Date: Thu Jul 12 17:38:49 2018 +0200

    Update/upgrade commands for services with external installers

    New `openstack overcloud external-update run` and `openstack overcloud
    external-upgrade run` commands are defined. These are meant to perform
    updates and upgrades for services deployed via
    external_deploy_tasks. A separate command is used because external
    installers don't fit well within the --nodes and --roles selection
    pattern we've established for the normal `update run` and `upgrade
    run` commands.

    Partial-Bug: #1783949
    Depends-On: Ib2474e8f69711cd6610a78884d5032ffd19ad249
    Depends-On: I982032a0eadfbfb7f1eadee9cae26c8cd5fcdbba
    Change-Id: Ib2f32ae8ac234b0c25b0e1ff1f8f8d8e041185e0

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/582619
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=ba31c7afc0302c86fa088d51bf8cb5df0da038f3
Submitter: Zuul
Branch: master

commit ba31c7afc0302c86fa088d51bf8cb5df0da038f3
Author: Jiri Stransky <email address hidden>
Date: Fri Jul 13 17:06:17 2018 +0200

    Drop obsolete `overcloud ceph-upgrade run`

    After switching from Heat workflow resources to external_deploy_tasks,
    the `ceph-upgrade run` command no longer works and can be
    dropped. Instead we'll be using `external-update run` and
    `external-upgrade run` commands.

    Partial-Bug: #1783949
    Change-Id: I228ce6228d0bd0bd4d40bc7a7cdd6bfe98a7a6ed

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/582624
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b82f743ab1f9ceef1eb13c093043c9808ccd25f7
Submitter: Zuul
Branch: master

commit b82f743ab1f9ceef1eb13c093043c9808ccd25f7
Author: Jiri Stransky <email address hidden>
Date: Fri Jul 13 17:30:54 2018 +0200

    Drop obsolete environment for `overcloud ceph-upgrade run`

    After switching from Heat workflow resources to external_deploy_tasks,
    the `ceph-upgrade run` command no longer works and can be
    dropped. Instead we'll be using `external-update run` and
    `external-upgrade run` commands, which will not do stack update. It
    will run Ansible and for Ceph specifically it will set the necessary
    playbook directly via Ansible.

    Partial-Bug: #1783949
    Change-Id: I3490163bc426d070e245387201d64e07b908c74f
    Depends-On: I228ce6228d0bd0bd4d40bc7a7cdd6bfe98a7a6ed

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/585366
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=790fea0a63aa057108d843645d93ead2587691d2
Submitter: Zuul
Branch: master

commit 790fea0a63aa057108d843645d93ead2587691d2
Author: Jiri Stransky <email address hidden>
Date: Tue Jul 24 15:40:03 2018 +0200

    Remove parameter for ceph-ansible playbook from update/upgrade prepare

    The parameter was necessary before we inherited the update/upgrade
    prepare commands from the deploy command. Nowadays this is not
    necessary and can be achieved by 2 different means: either via the
    *-prepare.yaml files setting CephAnsiblePlaybook parameter, or via
    external_update_tasks and external_upgrade_tasks.

    Partial-Bug: #1783949
    Change-Id: If54e12dbac1a982e89d29b96d86f9f5299e3d810
    Depends-On: If80f9cc2f4cb32610dc5eb87159872e28363a21a

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/585368
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=9175cd26b6db5d00527e094623e68d911b948575
Submitter: Zuul
Branch: master

commit 9175cd26b6db5d00527e094623e68d911b948575
Author: Jiri Stransky <email address hidden>
Date: Tue Jul 24 15:25:15 2018 +0200

    Remove ceph-specific logic from update/upgrade prepare workflow

    The logic was necessary before we inherited the update/upgrade prepare
    commands from the deploy command. Nowadays this is not necessary and
    can be achieved by 2 different means: either via the *-prepare.yaml
    files setting CephAnsiblePlaybook parameter, or via
    external_update_tasks and external_upgrade_tasks.

    Partial-Bug: #1783949
    Change-Id: Ifdf5f1175849f79b98c76b4bcdef2a70f8f1fedb
    Depends-On: If54e12dbac1a982e89d29b96d86f9f5299e3d810

Changed in tripleo:
milestone: rocky-rc1 → rocky-rc2
Changed in tripleo:
milestone: rocky-rc2 → stein-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/583321
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=20f614ba9a2cbdbbce9ebb2d8f51b87e273be850
Submitter: Zuul
Branch: master

commit 20f614ba9a2cbdbbce9ebb2d8f51b87e273be850
Author: Jiri Stransky <email address hidden>
Date: Tue Jul 17 12:39:52 2018 +0200

    Ceph update and upgrade in config-download era

    Correct playbook selection is now done automatically using
    external_update_tasks and external_upgrade_tasks. The
    CephAnsiblePlaybook is still usable and highest priority if set to
    something else than the default. It can also be set to [] to
    completely skip ceph-ansible playbook execution.

    Closes-Bug: #1783949
    Change-Id: If7955b31eda432dd61331281ad3d8f25a335fdfe
    Depends-On: Ifdf5f1175849f79b98c76b4bcdef2a70f8f1fedb

Changed in tripleo:
status: In Progress → Fix Released
tags: added: rocky-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/597419

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.openstack.org/597419
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=687aae24f70b885ffe37193c564e3741674ae18a
Submitter: Zuul
Branch: stable/rocky

commit 687aae24f70b885ffe37193c564e3741674ae18a
Author: Jiri Stransky <email address hidden>
Date: Tue Jul 17 12:39:52 2018 +0200

    Ceph update and upgrade in config-download era

    Correct playbook selection is now done automatically using
    external_update_tasks and external_upgrade_tasks. The
    CephAnsiblePlaybook is still usable and highest priority if set to
    something else than the default. It can also be set to [] to
    completely skip ceph-ansible playbook execution.

    Closes-Bug: #1783949
    Change-Id: If7955b31eda432dd61331281ad3d8f25a335fdfe
    Depends-On: Ifdf5f1175849f79b98c76b4bcdef2a70f8f1fedb
    (cherry picked from commit 20f614ba9a2cbdbbce9ebb2d8f51b87e273be850)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/587802
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=4504aadef69fc2366d3e959e1460138c85ec6ab2
Submitter: Zuul
Branch: master

commit 4504aadef69fc2366d3e959e1460138c85ec6ab2
Author: Jiri Stransky <email address hidden>
Date: Wed Aug 1 13:02:50 2018 +0200

    Allow performing Ceph update/upgrade separately

    Running `openstack overcloud external-update run` will update all
    external services. This commit adds possibility of running `openstack
    overcloud external-update run --tags ceph` to specifically update just
    Ceph. It works analogically for upgrades.

    Change-Id: Ic1786b6dbfa54516bfb836b450fc35452dca8cb5
    Partial-Bug: #1783949

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/599968

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.openstack.org/599968
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=abfe4ba43ff8fad627881c943c52a748c5ecd88a
Submitter: Zuul
Branch: stable/rocky

commit abfe4ba43ff8fad627881c943c52a748c5ecd88a
Author: Jiri Stransky <email address hidden>
Date: Wed Aug 1 13:02:50 2018 +0200

    Allow performing Ceph update/upgrade separately

    Running `openstack overcloud external-update run` will update all
    external services. This commit adds possibility of running `openstack
    overcloud external-update run --tags ceph` to specifically update just
    Ceph. It works analogically for upgrades.

    Change-Id: Ic1786b6dbfa54516bfb836b450fc35452dca8cb5
    Partial-Bug: #1783949
    (cherry picked from commit 4504aadef69fc2366d3e959e1460138c85ec6ab2)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 9.0.0.0rc2

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 10.0.0

This issue was fixed in the openstack/tripleo-heat-templates 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.