openstack tripleo container image prepare default --local-push-destination sets push_destination to localhost:8787

[Marius Cornea]

openstack tripleo container image prepare default --local-push-destination sets push_destination to localhost:8787 when it is run before the undercloud is installed.

We should be able to specify the address for push_destination option or read it from undercloud.conf because during undercloud installation port 8787 is listening only on the br-ctlplane interface IP address.

[Steve Baker (steve-stevebaker)]

We've just discussed this, and we've decided that running "openstack tripleo container image prepare default --local-push-destination" should generate a file containing push_destination:true, then the registry IP will look for true and convert that to the undercloud registry IP at upload time.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/585589

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/585590

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/585589
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=b5a2730ea2b0cac69ca410ec4840e29e6b81c3de
Submitter: Zuul
Branch: master

commit b5a2730ea2b0cac69ca410ec4840e29e6b81c3de
Author: Steve Baker <email address hidden>
Date: Wed Jul 25 13:47:54 2018 +1200

    Allow deferred undercloud push_destination detection

    By setting push_destination: True, it is possible to indicate that
    images should be uploaded to the undercloud registry before the
    registry is even installed. At upload time push_destination:True will
    be converted into the discovered undercloud registry.

    Change-Id: I8a35755ac28c419490159f3cb0f60b7d54f3958d
    Partial-Bug: #1783204

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/585590
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=205431b179d751e26b9a9d5f490e923893f21535
Submitter: Zuul
Branch: master

commit 205431b179d751e26b9a9d5f490e923893f21535
Author: Steve Baker <email address hidden>
Date: Wed Jul 25 14:01:21 2018 +1200

    Prepare defaults, defer detecting undercloud registry

    Now that the undercloud is containerized, the following command will
    sometimes need to be run before the undercloud is installed:

      openstack tripleo container image prepare default --local-push-destination

    Doing this currently results in push_destination:localhost:8787
    because the required network interface doesn't yet exist for the
    registry detection logic.

    This change will make push_destination be set to True, so that the
    registry address is detected at upload time, which is late enough in
    the undercloud install to actually work.

    Change-Id: I69a30be9372dc2349b3339019be9d45b632f4a74
    Closes-Bug: #1783204
    Depends-On: I8a35755ac28c419490159f3cb0f60b7d54f3958d

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/591257

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/591257
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5ba17936fb457e2bdababb83471e428d7287f49e
Submitter: Zuul
Branch: master

commit 5ba17936fb457e2bdababb83471e428d7287f49e
Author: Bogdan Dobrelya <email address hidden>
Date: Fri Aug 10 17:12:55 2018 +0200

    Support push_destination:true in prepare

    The fix for bug #1783204 only handled the upload logic in isolation,
    and didn't account for the whole prepare flow. This change completes
    push_destination:true support with the following changes:
    - container_images_prepare_multi, which is the heat parameter driven
      interface for prepare, use heat parameter LocalContainerRegistry as
      the registry IP, which is only set during undercloud install. This
      handles the case where registry discovery won't work because it is too
      early in the undercloud install process
    - container_images_prepare, which is the python library API for
      prepare, make the image registry substitution support
      push_destination:true. The discovery logic can be used here since
      this is only ever called after networking is configured on the
      undercloud

    Change-Id: Ia18c89a48ef0fd0f3021823c6049042ac5e78eb8
    Related-Bug: #1783204
    Closes-Bug: #1786521

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 10.5.0 release.