disable-telemetry.yaml does not set [oslo_messaging_notifications]/driver to noop in heat.conf

Bug #1782720 reported by Rabi Mishra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Rabi Mishra

Bug Description

We seem to have service profile parameter[1] which defaults to 'messaging' and it overrides the one set in the service[2]

[1] https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/heat.pp#L89
[2] https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/heat-base.yaml#L152

Rabi Mishra (rabi)
Changed in tripleo:
assignee: nobody → Rabi Mishra (rabi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (master)

Fix proposed to branch: master
Review: https://review.openstack.org/584270

Changed in tripleo:
status: New → In Progress
Changed in tripleo:
importance: Undecided → Medium
milestone: none → rocky-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.openstack.org/584270
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=77a158bdd8ce13800d61b262a27b00e91945dba2
Submitter: Zuul
Branch: master

commit 77a158bdd8ce13800d61b262a27b00e91945dba2
Author: rabi <email address hidden>
Date: Fri Jul 20 12:52:38 2018 +0530

    Remove notification_driver parameter from heat profile

    The service profile has a default that overrides the one set either
    by 'NotificationDriver' parameter or 'heat::notification_driver' in
    ExtraConfig.

    This parameter is not there in any other service profile and can
    be removed as it's not used by the service.

    Change-Id: I1570f59be977773ba8a0ff1222b57f88a9954ca8
    Closes-Bug: #1782720

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/585129

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/585617

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/585620

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 9.2.0

This issue was fixed in the openstack/puppet-tripleo 9.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/queens)

Reviewed: https://review.openstack.org/585129
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=83e4253289589d26372cd8170669f1afad620a96
Submitter: Zuul
Branch: stable/queens

commit 83e4253289589d26372cd8170669f1afad620a96
Author: rabi <email address hidden>
Date: Fri Jul 20 12:52:38 2018 +0530

    Remove notification_driver parameter from heat profile

    The service profile has a default that overrides the one set either
    by 'NotificationDriver' parameter or 'heat::notification_driver' in
    ExtraConfig.

    This parameter is not there in any other service profile and can
    be removed as it's not used by the service.

    Change-Id: I1570f59be977773ba8a0ff1222b57f88a9954ca8
    Closes-Bug: #1782720
    (cherry picked from commit 77a158bdd8ce13800d61b262a27b00e91945dba2)

tags: added: in-stable-queens
tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/ocata)

Reviewed: https://review.openstack.org/585620
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=f34d66471457e95b50fd5c9762023f4e9ac46f39
Submitter: Zuul
Branch: stable/ocata

commit f34d66471457e95b50fd5c9762023f4e9ac46f39
Author: rabi <email address hidden>
Date: Fri Jul 20 12:52:38 2018 +0530

    Remove notification_driver parameter from heat profile

    The service profile has a default that overrides the one set either
    by 'NotificationDriver' parameter or 'heat::notification_driver' in
    ExtraConfig.

    This parameter is not there in any other service profile and can
    be removed as it's not used by the service.

    Change-Id: I1570f59be977773ba8a0ff1222b57f88a9954ca8
    Closes-Bug: #1782720
    (cherry picked from commit 77a158bdd8ce13800d61b262a27b00e91945dba2)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/pike)

Reviewed: https://review.openstack.org/585617
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=e958ecf38b2ebfa0e9e7a9b0f330f8a34cb806e7
Submitter: Zuul
Branch: stable/pike

commit e958ecf38b2ebfa0e9e7a9b0f330f8a34cb806e7
Author: rabi <email address hidden>
Date: Fri Jul 20 12:52:38 2018 +0530

    Remove notification_driver parameter from heat profile

    The service profile has a default that overrides the one set either
    by 'NotificationDriver' parameter or 'heat::notification_driver' in
    ExtraConfig.

    This parameter is not there in any other service profile and can
    be removed as it's not used by the service.

    Change-Id: I1570f59be977773ba8a0ff1222b57f88a9954ca8
    Closes-Bug: #1782720
    (cherry picked from commit 77a158bdd8ce13800d61b262a27b00e91945dba2)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 6.5.15

This issue was fixed in the openstack/puppet-tripleo 6.5.15 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 7.4.15

This issue was fixed in the openstack/puppet-tripleo 7.4.15 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 8.3.5

This issue was fixed in the openstack/puppet-tripleo 8.3.5 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.