cephfs native environment file is broken

[Tom Barron]

https://review.openstack.org/#/c/471245/ changed the names of parameters in puppet/services/manila-backend-cephfs.yaml to begin with 'ManilaCephFS' rather than 'ManilaCephFSNative' and added a new parameter 'ManilaCephFSCephFSProtocolType' to discriminate between the CephFS-Native and CephFS-NFS cases.

Although environments/manila-cephfsnative-config-docker.yaml was changed to use the new parameter prefixes, environments/manila-cephfsnative-config.yaml still uses the old 'ManilaCephFSNative' prefixes and is broken.

The new ManilaCephFS parameters were given default values that ensured backwards compatability with the default values set for corresponding ManilaCephFSNative parameters, but if the latter were set to a non-default value (e.g. one can legitimately set ManilaCephFSNativeCephFSEnableSnapshots to 'true') then the setting has no effect.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/583705
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=08e67b8ff02db3ccf82fd96a0c8ff2eb17a2988b
Submitter: Zuul
Branch: master

commit 08e67b8ff02db3ccf82fd96a0c8ff2eb17a2988b
Author: Tom Barron <email address hidden>
Date: Wed Jul 18 15:21:42 2018 -0400

    Update manila environment file names

    to eliminate special 'docker' names.

    Containerized manila is now the standard way to deploy
    so we can avoid confusion by just using the regular
    manila environment file names for these rather than having
    some manila environment files with 'docker' in their names.

    Note that we are using the content of
    environments/manila-cephfsnative-config-docker.yaml
    for
    environments/manila-cephfsnative-config.yaml. This resolves an
    issue wherein the parameters in the latter file were not updated
    when support for the CephFS-NFS back end was added [1].

    Closes-Bug: #1782622

    [1] Ib408c7827e5fba0c1b01388db26363806fc64370

    Change-Id: I08431d848158846a434fecc98d3bee838c7fad68

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/585190

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/585190
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c48a1f02c9fbaea9c9b9f89b14f6be2017bff806
Submitter: Zuul
Branch: stable/queens

commit c48a1f02c9fbaea9c9b9f89b14f6be2017bff806
Author: Tom Barron <email address hidden>
Date: Wed Jul 18 15:21:42 2018 -0400

    Update manila environment file names

    to eliminate special 'docker' names.

    Containerized manila is now the standard way to deploy
    so we can avoid confusion by just using the regular
    manila environment file names for these rather than having
    some manila environment files with 'docker' in their names.

    Note that we are using the content of
    environments/manila-cephfsnative-config-docker.yaml
    for
    environments/manila-cephfsnative-config.yaml. This resolves an
    issue wherein the parameters in the latter file were not updated
    when support for the CephFS-NFS back end was added [1].

    Closes-Bug: #1782622

    [1] Ib408c7827e5fba0c1b01388db26363806fc64370

    Change-Id: I08431d848158846a434fecc98d3bee838c7fad68

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b4 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.5 release.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/621487

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/621487
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=841e175110bb8d61ff87f80f16f01f4b8366fd31
Submitter: Zuul
Branch: master

commit 841e175110bb8d61ff87f80f16f01f4b8366fd31
Author: Rabi Mishra <email address hidden>
Date: Mon Dec 3 12:17:52 2018 +0530

    Update manila environment file name in capabilities-map

    In commit 08e67b8ff02db3ccf82fd96a0c8ff2eb17a2988b environment
    file names were changed to remove 'docker'. However, capabilities
    map still has a wrong entry.

    Change-Id: Id6877a135adbdaa6b2bff77333e2c9f6fbd9efba
    Related-Bug: #1782622

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.openstack.org/644765

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/644765
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=65a1858859b1adba3133ebe9d287ba74f2a42e91
Submitter: Zuul
Branch: stable/rocky

commit 65a1858859b1adba3133ebe9d287ba74f2a42e91
Author: Rabi Mishra <email address hidden>
Date: Mon Dec 3 12:17:52 2018 +0530

    Update manila environment file name in capabilities-map

    In commit 08e67b8ff02db3ccf82fd96a0c8ff2eb17a2988b environment
    file names were changed to remove 'docker'. However, capabilities
    map still has a wrong entry.

    Change-Id: Id6877a135adbdaa6b2bff77333e2c9f6fbd9efba
    Related-Bug: #1782622
    (cherry picked from commit 841e175110bb8d61ff87f80f16f01f4b8366fd31)