Overcloud upgrade CI job doesn't load templates from /usr/share/openstack-tripleo-heat-templates

[Emilien Macchi]

When we try to enable the containerized undercloud in overcloud upgrade job, it fails to load the version of THT deployed on the host in /usr/share:
http://logs.openstack.org/55/579755/11/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/b882011/logs/undercloud/home/zuul/undercloud_install.log.txt.gz#_2018-07-11_03_50_31

It's deploying the queens while we want the one from Rocky (current master).
Note the undercloud should be deployed on Rocky.

[Bogdan Dobrelya (bogdando)]

Addressed by: https://review.openstack.org/#/c/465047/

[Bogdan Dobrelya (bogdando)]

Addressed by: https://review.openstack.org/#/c/582529/

[Bogdan Dobrelya (bogdando)]

The containerized UC is temporary disabled for the upgrade job https://review.openstack.org/#/c/579755/14/config/general_config/featureset051.yml

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/582916

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: master
Review: https://review.openstack.org/582916
Reason: this does not fit the model of --templates designed cases, which is

1. --templates (no args, uses default /usr/share location)
2. --templates foo (foo must exist, so we use it)

also, there was a -compat RPM for exactly this purpose (diverging the mixed tht paths) a while back

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465047
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=36569be28d67fd130c7ac79d859f83ace630c672
Submitter: Zuul
Branch: master

commit 36569be28d67fd130c7ac79d859f83ace630c672
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Mar 28 15:42:52 2017 +0200

    Unify custom t-h-t install steps for UC/OC/upgrade

    Allow undercloud installations/upgrades from custom t-h-t, similarly to
    overcloud_templates_* et al.

    Unify and share custom t-h-t install script for OC and UC and mixed
    update/upgrade cases via new shared role tht-prep-config.

    To diverge undercloud from overcloud install/update/upgrade cases, use
    the following shared mappings (vars on the right correspond to UC
    cases):

      * tht_templates_path: undercloud_templates_path (defaults to RPM dir)
      * tht_templates_repo: undercloud_templates_repo
      * tht_templates_branch: undercloud_templates_branch
      * tht_templates_refspec: undercloud_templates_refspec

    and a 2nd group (defaults set to do nothing, but only disable the
    t-h-t prepare script's code blocks under control of those):

      * composable_scenario: undercloud_composable_scenario
      * upgrade_composable_scenario: undercloud_upgrade_composable_scenario
      * prep_post_hook_script: undercloud_prep_post_hook_script
      * download_templates_rpm: download_undercloud_templates_rpm
      * tht_rpm_url: undercloud_tht_rpm_url

    Those in group 2 may be customized to mimic the overcloud mixed
    upgrades logic for underclouds/all-in-one for future use.

    And for overclouds respectively, use mappings:

      * composable_scenario: remains unchanged
      * upgrade_composable_scenario: remains unchanged
      * prep_post_hook_script: overcloud_prep_post_hook_script
      * download_templates_rpm: download_overcloud_templates_rpm
      * tht_rpm_url: remains unchanged
      * tht_templates_path: overcloud_templates_path
      ...

    Related-bug: #1691467
    Closes-bug: #1781227
    Change-Id: I4e0dcf24b93b8e4afb8359cb5108c4b7b5ba3d55
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.