No shared with containerized UC images skipped when preparing for overcloud deployment

[Bogdan Dobrelya]

Looking into the fs010 job logs [0], I can see only events logged with [1].
and nothing hits the 'Skipping' code [2]. In the end, it takes ~25 minutes

2018-07-05 02:31:11.568749 | primary | overcloud-prep-containers : Prepare for the containerized deployment - 1483.79s

 to prepare the overcloud images, while I'd expect it should take much shorter, given that many containerized services was already deployed undercloud from the same images and should be sitting in the local registry.

[0] http://logs.openstack.org/45/560445/78/check/tripleo-ci-centos-7-containers-multinode/ead40a6/logs/undercloud/home/zuul/overcloud_prep_containers.log.txt.gz
[1] http://git.openstack.org/cgit/openstack/tripleo-common/tree/tripleo_common/image/image_uploader.py#n266
[2] http://git.openstack.org/cgit/openstack/tripleo-common/tree/tripleo_common/image/image_uploader.py#n238

[Bogdan Dobrelya (bogdando)]

Oh, for some reason I missed that fs010 is not running containerized UC anymore
http://logs.openstack.org/45/560445/78/check/tripleo-ci-centos-7-containers-multinode/ead40a6/logs/undercloud/home/zuul/undercloud-install.sh.txt.gz

[Bogdan Dobrelya (bogdando)]

Yeah, I can confirm the skipping code works for the containerized UC and OC https://logs.rdoproject.org/45/560445/78/openstack-check/legacy-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-master/1de740c/logs/undercloud/home/zuul/overcloud_prep_containers.log.txt.gz