os-refresh-config undercloud install Error: Evaluation Error: Error while evaluating a Function Call, pick(): must receive at least one non empty

[Quique Llorente]

Running some noop change fails undercloud install

http://logs.openstack.org/45/560445/68/check/tripleo-ci-centos-7-scenario001-multinode-oooq-container/ed9e742/logs/undercloud/home/zuul/undercloud_install.log.txt.gz#_2018-06-22_08_39_52

2018-06-22 08:39:52 | 2018-06-22 08:39:52,158 INFO: Warning: Unknown variable: '::nova::api::default_floating_pool'. at /etc/puppet/modules/nova/manifests/network/neutron.pp:112:38
2018-06-22 08:39:52 | 2018-06-22 08:39:52,470 INFO: Warning: Scope(Class[Ironic::Api::Authtoken]): The auth_uri parameter is deprecated. Please use www_authenticate_uri instead.
2018-06-22 08:39:52 | 2018-06-22 08:39:52,836 INFO: Error: Evaluation Error: Error while evaluating a Function Call, pick(): must receive at least one non empty value at /etc/puppet/modules/ironic/manifests/drivers/pxe.pp:102:33 on node centos-7-ovh-gra1-0000291369
2018-06-22 08:39:52 | 2018-06-22 08:39:52,893 INFO: + rc=1
2018-06-22 08:39:52 | 2018-06-22 08:39:52,893 INFO: + set -e
2018-06-22 08:39:52 | 2018-06-22 08:39:52,893 INFO: + echo 'puppet apply exited with exit code 1'
2018-06-22 08:39:52 | 2018-06-22 08:39:52,894 INFO: puppet apply exited with exit code 1
2018-06-22 08:39:52 | 2018-06-22 08:39:52,894 INFO: + '[' 1 '!=' 2 -a 1 '!=' 0 ']'
2018-06-22 08:39:52 | 2018-06-22 08:39:52,894 INFO: + exit 1
2018-06-22 08:39:52 | 2018-06-22 08:39:52,894 INFO: [2018-06-22 08:39:52,894] (os-refresh-config) [ERROR] during configure phase. [Command '['dib-run-parts', '/usr/libexec/os-refresh-config/configure.d']' returned non-zero exit status 1]
2018-06-22 08:39:52 | 2018-06-22 08:39:52,895 INFO:
2018-06-22 08:39:52 | 2018-06-22 08:39:52,895 INFO: [2018-06-22 08:39:52,894] (os-refresh-config) [ERROR] Aborting...
2018-06-22 08:39:52 | 2018-06-22 08:39:52,902 DEBUG: An exception occurred
2018-06-22 08:39:52 | Traceback (most recent call last):
2018-06-22 08:39:52 | File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 2282, in install
2018-06-22 08:39:52 | _run_orc(instack_env)
2018-06-22 08:39:52 | File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 1587, in _run_orc
2018-06-22 08:39:52 | _run_live_command(args, instack_env, 'os-refresh-config')
2018-06-22 08:39:52 | File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 669, in _run_live_command
2018-06-22 08:39:52 | raise RuntimeError('%s failed. See log for details.' % name)
2018-06-22 08:39:52 | RuntimeError: os-refresh-config failed. See log for details.
2018-06-22 08:39:52 | 2018-06-22 08:39:52,903 ERROR:
2018-06-22 08:39:52 | #############################################################################

[Dmitry Tantsur (divius)]

> Error: Evaluation Error: Error while evaluating a Function Call, pick(): must receive at least one non empty value at /etc/puppet/modules/ironic/manifests/drivers/pxe.pp:102:33

I don't quite get how this line can cause it:

 $pxe_config_template_real = pick($pxe_config_template, '$pybasedir/drivers/modules/ipxe_config.template')

https://github.com/openstack/puppet-ironic/blob/master/manifests/drivers/pxe.pp#L102

[Dmitry Tantsur (divius)]

It seems that we're broken by https://github.com/puppetlabs/puppetlabs-stdlib/commit/2a493adcd01ece80cb70fab004e2fb8b01261775 as it now tries to expand $pybasedir (which is a literal part of the value).

[Dmitry Tantsur (divius)]

https://github.com/puppetlabs/puppetlabs-stdlib/pull/890 introduced the breaking change 2 hours ago

[Quique Llorente (quiquell)]

Possible fix at puppet-ironic https://review.openstack.org/#/c/577386/

[Quique Llorente (quiquell)]

Pinning to a known good version of puppet stdlib https://review.rdoproject.org/r/#/c/14432/1

[OpenStack Infra (hudson-openstack)]

Change abandoned by Quique Llorente (<email address hidden>) on branch: master
Review: https://review.openstack.org/577386

[Alex Schultz (alex-schultz)]

https://github.com/puppetlabs/puppetlabs-stdlib/pull/927

[Alex Schultz (alex-schultz)]

upstream reverts all around