instack-undercloud calls the Mistral action tripleo.validations.upload but doesn't verify it was succesful

[Dougal Matthews]

Really we should wait and check the action exection completed without errors. At the moment it is just a fire and forget. http://git.openstack.org/cgit/openstack/instack-undercloud/tree/instack_undercloud/undercloud.py#n1897

See also https://bugs.launchpad.net/tripleo/+bug/1640436, which has some details on why we discourage direct action calls like this. It would be better to wrap this in a simple workflow.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/576126

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/576145

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/576147

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/576126
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=f827ee93aa1aebaea37fef28d1c7d624688faa46
Submitter: Zuul
Branch: master

commit f827ee93aa1aebaea37fef28d1c7d624688faa46
Author: Ana Krivokapic <email address hidden>
Date: Mon Jun 18 14:55:58 2018 +0200

    Add workflow for uploading validations to Swift

    Change-Id: I55be508ce5906c2f12068ae1713657eab2f658fd
    Partial-Bug: #1774185
    Partial-Bug: #1640436

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/576145
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=a7b7f345a94d9f65a006003e446b8cc05f56a500
Submitter: Zuul
Branch: master

commit a7b7f345a94d9f65a006003e446b8cc05f56a500
Author: Ana Krivokapic <email address hidden>
Date: Mon Jun 18 15:41:01 2018 +0200

    Call validations upload workflow instead of action

    Change-Id: Ifcf813b51053c8e1ab57c1cc031a4c980f198c69
    Partial-Bug: #1774185
    Depends-On: I55be508ce5906c2f12068ae1713657eab2f658fd

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/576147
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c8d6b50b3eea209f4556111232874d94b34a7810
Submitter: Zuul
Branch: master

commit c8d6b50b3eea209f4556111232874d94b34a7810
Author: Ana Krivokapic <email address hidden>
Date: Mon Jun 18 15:48:16 2018 +0200

    Call validations upload workflow instead of action

    Change-Id: Ib570e7da9e6548fb620758d8a878842d8b05be26
    Closes-Bug: #1774185
    Depends-On: I55be508ce5906c2f12068ae1713657eab2f658fd

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/581202

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/581202
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=e9089dcf8bbb15bb0fbd13ced1d9e6b50bac4784
Submitter: Zuul
Branch: master

commit e9089dcf8bbb15bb0fbd13ced1d9e6b50bac4784
Author: yatin <email address hidden>
Date: Tue Jul 10 11:09:49 2018 +0530

    Re add upload_validations

    Removed in [1] but it's required at [2] and [3].

    [1] https://review.openstack.org/#/c/564204/
    [2] https://review.openstack.org/#/c/576145/
    [3] https://review.openstack.org/#/c/576147/

    Related-Bug: #1774185
    Change-Id: I289b0f0a07ff892d367c8838377e4ccaa5d81d1e

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b4 development milestone.