tripleo

enable-ssh-admin.sh should use private key also when deleting the temp keys

Bug #1773980 reported by James Slagle on 2018-05-29

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Medium	James Slagle	tripleo rocky-3

Bug Description

we use the user specified private key to inject the temporary ssh key, but not when we delete the temporary key. we should use it both places.

Tags:

James Slagle (james-slagle) on 2018-05-29

Changed in tripleo:
status:	New → In Progress
importance:	Undecided → Medium
assignee:	nobody → James Slagle (james-slagle)
milestone:	none → rocky-2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-05-29: Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/570933

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-05-29: Fix proposed to tripleo-heat-templates (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/570935

Emilien Macchi (emilienm) on 2018-06-05

Changed in tripleo:
milestone:	rocky-2 → rocky-3

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-13: Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/570933
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d04e7ea4f3fce0c787c3eed6f1840b402435113c
Submitter: Zuul
Branch: master

commit d04e7ea4f3fce0c787c3eed6f1840b402435113c
Author: James Slagle <email address hidden>
Date: Tue May 29 08:53:19 2018 -0400

Use user specified private key when deleting temp keys

    We use the user specified private key when we inject the temporary ssh
    key, and we should also use it when we delete the temprorary ssh keys.
    Even though this script is no longer used on master, we should commit
    this so we can backport to queens.

Change-Id: Id389984b87209f959e4cf439abd8165a3a08ead3
Closes-Bug: #1773980

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-06-16: Fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.openstack.org/570935
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=094cf968e97f0212d6313f3efcada9070207ec77
Submitter: Zuul
Branch: stable/queens

commit 094cf968e97f0212d6313f3efcada9070207ec77
Author: James Slagle <email address hidden>
Date: Tue May 29 08:53:19 2018 -0400

Use user specified private key when deleting temp keys

    Change-Id: Id389984b87209f959e4cf439abd8165a3a08ead3
    Closes-Bug: #1773980
    (cherry picked from commit d04e7ea4f3fce0c787c3eed6f1840b402435113c)