Mixed version (R/Q) deploy with config-download cannot find role_name variable

[Jiří Stránský]

Q->R upgrade job, which does mixed version deploy (R UC, Q OC) fails with:

2018-05-18 09:17:31 | TASK [create persistent logs directory] ****************************************
2018-05-18 09:17:31 | fatal: [centos-7-inap-mtl01-0004082484]: FAILED! => {"failed": true, "msg": "The conditional check 'role_name == 'Controller'' failed. The error was: error while evaluating conditional (role_name == 'Controller'): 'role_name' is undefined\n\nThe error appears to have been in '/var/lib/mistral/0a311d1e-c3e5-4e87-93dd-0b065723e399/Controller/host_prep_tasks.yaml': line 1, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- file:\n ^ here\n"}
2018-05-18 09:17:31 |

We probably shouldn't backport the inventory change and the templates change that are related to this:

https://github.com/openstack/tripleo-heat-templates/commit/1bec01137eca33fa210daa044571629b6ff848b8

Instead it would be best to deploy Queens without config-download.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/569381

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/569381
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=a7dc4fa42459278eedc7ab09f3dd9048686e4af5
Submitter: Zuul
Branch: master

commit a7dc4fa42459278eedc7ab09f3dd9048686e4af5
Author: Jiri Stransky <email address hidden>
Date: Fri May 18 12:36:41 2018 +0200

    Mixed version R/Q deploy -- don't use config download

    There has been an inventory and templates change in R undercloud,
    variable rename from role_name to tripleo_role_name, to avoid
    conflicting with internal ansible vars. This makes the R undercloud
    config-download mechanisms incompatible with Q templates.

    Use --no-config-download when deploying Q OC with R UC to prevent
    hitting this issue.

    Change-Id: I0d5fc04f596787c77cac60656f52be76ac1b8829
    Closes-Bug: #1771997

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart 2.1.1 release.