hubbot: TQE check jobs have not been kicked by hubbot since 4/25
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo |
Fix Released
|
Critical
|
Sagi (Sergey) Shnaidman |
Bug Description
The 'hubbot' bot in #oooq running on tripleo-ci's infra tenant has not rechecked the review for TQE since april 24th. The bot watches the following:
hubbot check jobs:
TQE, https:/
THT, https:/
THT, https:/
THT, https:/
This can be confirmed by sending the following message to the bot (privately, or with a '%' prepended in the #oooq freenode channel)
---
[16:20:58] <myoung|ruck> config plugins.
[16:20:58] [hubbot] I9af1028314859b
---
The first patch on the list (560445) should be have the bot rechecking periodically, but that doesn't seem to be happening.
Changed in tripleo: | |
assignee: | nobody → Sagi (Sergey) Shnaidman (sshnaidm) |
status: | Triaged → Fix Released |
The bot has 2 issues that were surfaced.
- it's not filtering out abandoned changes
- It can't handle 2 patches with the same change id, which is an edge case occuring when a cherry pick from one branch to another occurs without changing the Change-Id in the commit message. Gerrit makes a distinction, however when 2 patches have the same id (on different branches) the bot was selecting the first patch, (which was abandoned on the master branch).
We've updated the bot's .conf file on the hubbot server (tripleo-infra tenant of RDO Cloud) and the patches in gerrit to all have unique ID's. The bot is now monitoring the following:
- TQE, 560445, I214272a6f25feb 75496e44eb0a162 69c6ee4cfe2 1e4dd891c38702f f8d1f6db5b1, stable/queens 98a4842f2793992 85344f22246, stable/pike eabf669b248b99c b8443e82fab, stable/ocata
- THT, 567224, I0cbf9ffb855241
- THT, 564285, If12c8fe9bd0bea
- THT, 564291, I4c5bdf00ce8cf7