containerized-undercloud-upgrades: dlrn tasks don't run

[Emilien Macchi]

With the new shiny CI job that test upgrades from an undercloud (not containerized) on Queens, which is then upgraded to a containerized Rocky undercloud, quickstart never runs the Ansible tasks that build deloreans package for the project that we're testing. e.g python-tripleoclient.

You can see the "build or not to build" thing:
http://logs.openstack.org/67/566067/1/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/c84191e/job-output.txt.gz#_2018-05-03_14_03_01_699534

That is skipped (why?). So because we skip it, we never run delorean so we don't actually test the change in the project.

After some debugging, we know that it happens for any project.

[wes hayutin (weshayutin)]

root cause is that with this job and any upgrade job atm. The variable "release" may not match the the release in the zuul change.

In this case the job starts with release "queens" but is triggered from a patch on master

- name: Clone and build the specific DLRN projects
  include: dlrn-build.yml artg_change={{ item }}
  with_items: '{{ artg_change_list|default([]) }}'
  when:
    - item.project not in artg_skipped_projects
    - release in item.branch

The correct solution to this issue is complex and is being worked on now in [2]

[1]https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/build-test-packages/tasks/main.yml#L139
[2]https://trello.com/c/cuKevn28/728-sprint-13-upgrades-goals

[wes hayutin (weshayutin)]

This may in fact fix the issue

https://review.openstack.org/#/c/561927/5/playbooks/multinode-overcloud-upgrade.yml

[wes hayutin (weshayutin)]

trying w/o the when condition https://review.openstack.org/#/c/566393/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/568946

[Ronelle Landy (rlandy)]

We have some initial test results using a patch based on the releases script integration into toci-quickstart - see logs: http://logs.openstack.org/31/568931/2/check/tripleo-ci-centos-7-containerized-undercloud-upgrades/9cae57f/logs/undercloud/home/zuul/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/568946
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=d13dc308fae4a12657238f0fd5afed03eeabb3c2
Submitter: Zuul
Branch: master

commit d13dc308fae4a12657238f0fd5afed03eeabb3c2
Author: Wes Hayutin <email address hidden>
Date: Wed May 16 15:45:06 2018 -0400

    execute the build / install of zuul changes in upgrade

    At the moment the build-test-packages and install-built-repo
    are only called in the n version not the n+1. If the
    dependency is master it will not get installed, however
    a queens patch would.

    Once we flip the upgrade role we need to recheck
    for zuul changes on the n+1 version and rebuild them
    if they are found

    Related-Bug: #1768997
    Change-Id: I1d1401753f4576317805bc4c556b37f71faa60ed