Deploy_plan workflow should skip create_swift_rings_backup_plan task unless swift service is deployed

Bug #1768596 reported by Martin André
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Expired
High
Unassigned

Bug Description

Currently the create_swift_rings_backup_plan task runs unconditionally in the deploy_plan workflow, whether or not swift service is deployed.

https://github.com/openstack/tripleo-common/blob/83c5cd1f7cf0ecc2160b6e27e624470ff8d5c4c9/workbooks/deployment.yaml#L161-L168

There are probably other tasks that are executed when there is no need to. This can potentially slow down the deployment by tens of seconds if not minutes.

We need a way to know from the mistral workflow, the list of services that are being deployed, and skip unneeded tasks.

One possibility (to be confirmed) would be to make use of the tripleo.parameters.update action which does a heat validate call. This should retrieve the *Services parameter values for all roles, and store a list of the enabled services.

Changed in tripleo:
status: New → Triaged
importance: Undecided → High
milestone: none → rocky-2
Changed in tripleo:
milestone: rocky-2 → rocky-3
Changed in tripleo:
milestone: rocky-3 → rocky-rc1
Changed in tripleo:
milestone: rocky-rc1 → stein-1
Changed in tripleo:
milestone: stein-1 → stein-2
Changed in tripleo:
milestone: stein-2 → stein-3
Revision history for this message
Juan Antonio Osorio Robles (juan-osorio-robles) wrote :

Is this still an issue?

Revision history for this message
Martin André (mandre) wrote :

Yes, this task is still run unconditionally, causing the deployment to take longer than needed in scenarios where swift isn't deployed -- tripleo deploying openshift for instance.

Changed in tripleo:
milestone: stein-3 → stein-rc1
Changed in tripleo:
milestone: stein-rc1 → train-1
Changed in tripleo:
milestone: train-1 → train-2
Changed in tripleo:
milestone: train-2 → train-3
Changed in tripleo:
milestone: train-3 → ussuri-1
Changed in tripleo:
milestone: ussuri-1 → ussuri-2
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-2 → ussuri-3
wes hayutin (weshayutin)
Changed in tripleo:
status: Triaged → Incomplete
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-3 → ussuri-rc3
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-rc3 → victoria-1
Changed in tripleo:
milestone: victoria-1 → victoria-3
Changed in tripleo:
milestone: victoria-3 → wallaby-1
Changed in tripleo:
milestone: wallaby-1 → wallaby-2
Changed in tripleo:
milestone: wallaby-2 → wallaby-3
Revision history for this message
Marios Andreou (marios-b) wrote :

This is an automated action. Bug status has been set to 'Incomplete' and target milestone has been removed due to inactivity. If you disagree please re-set these values and reach out to us on freenode #tripleo

Changed in tripleo:
milestone: wallaby-3 → none
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for tripleo because there has been no activity for 60 days.]

Changed in tripleo:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.