tripleoclient unit test fails on nic validation

[Alex Schultz]

When I run the tests locally I'm getting a a TypeError. This doesn't appear to be affecting the CI gates however.

running: tox -e py27

Results in:
======================================================================
FAIL: tripleoclient.tests.v1.overcloud_netenv_validate.test_overcloud_netenv_validate.TestValidateOvercloudNetenv.test_command
tags: worker-0
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tripleoclient/tests/v1/overcloud_netenv_validate/test_overcloud_netenv_validate.py", line 273, in test_command
    self.cmd.take_action(parsed_args)
  File "tripleoclient/v1/overcloud_netenv_validate.py", line 61, in take_action
    self.NIC_validate(item, data_path)
  File "tripleoclient/v1/overcloud_netenv_validate.py", line 177, in NIC_validate
    for item in nic_data['resources']:
TypeError: 'NoneType' object has no attribute '__getitem__'

[Alex Schultz (alex-schultz)]

Turns out it was because I had a file in /tmp called foo. We aren't mocking the test correctly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/565575

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/565575
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=24d6301d92ed4f1f482bbbb68d835c1c1b6a1039
Submitter: Zuul
Branch: master

commit 24d6301d92ed4f1f482bbbb68d835c1c1b6a1039
Author: Alex Schultz <email address hidden>
Date: Tue May 1 14:07:17 2018 -0600

    Fix test for netenv validate

    Previously we were actually attempting to open a file in the
    NIC_validate function when executed by this test because it was not
    properly mocked. If you had an empty file /tmp/foo, the test would fail
    because it would try and read data from it.

    Change-Id: Iab778b756637ae3e3a4beeea66bfa41b3cedd7b8
    Closes-Bug: #1768337

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 10.1.0 release.