promoter script is not comparing timestamps correctly when folding hashes

[Gabriele Cerami]

When the promoter looks at the timestamp to choose only to promote hashes older than the one previously promoted, it's comparing timestamps from two different promotions.

So for example, when trying to promote to current-tripleo-rdo we look at the last promotion timestamp, then try to find timestamps older than this among the current-tripleo promotions.
So, if the latest promotion to current-tripleo-rdo for hash A happened after a current-tripleo promotion for hash B (and it's happening only lately that we have so many promotions) then promotion to current-tripleo-rdo for hash B will be skipped.

We need to start also confronting the hash and be sure we are comparing timestamps at the same level (current-tripleo with current-tripleo)

[Gabriele Cerami (gcerami)]

I'll have to rewrite the get_latest_hashes function to do a comparison based on hashes instead of just timestamps.

[Gabriele Cerami (gcerami)]

Proposed patch https://review.rdoproject.org/13604, tested in the promoter server, stage environment with dry run, returns correct list of hashes.

[Gabriele Cerami (gcerami)]

The correct patch is at https://review.rdoproject.org/r/#/c/13604

[Matt Young (halcyondude)]

https://review.rdoproject.org/r/#/c/13604 still needs workflow, it's not released/commited

[Matt Young (halcyondude)]

flipped status back to in progress, we don't have "releases" of CI, and with this state it's not been showing up for triage.